v0.1.6: non-blocking login_browser for chat clients#4
Merged
Conversation
Claude Desktop / Cursor chat / Continue / Cline don't support `resetTimeoutOnProgress`, so any tool call exceeding ~60s gets killed client-side even if the server is still working. The previous login_browser blocked until the user submitted the form (5min ceiling) — in practice always timing out before the user finished typing. New behavior: - login_browser(wait=False) — DEFAULT for chat clients. Binds the local 127.0.0.1 server, opens the browser, returns the URL in <1s. The server keeps running in a daemon thread for `timeout` seconds. On user submit, the token is saved to config.json and (best-effort) the password is stored in OS keychain — exactly like the wait=True path. Agent shows URL to user, polls whoami afterwards to detect completion. - login_browser(wait=True) — opt-in for CLI/IDE agents that DO support long-running tools (Claude Code, Codex CLI). Same blocking behavior as before; returns full result inline with email/user_id. Refactor in web_auth.py to support this: - new `LoginSession` handle class - `start_login_server(...)` — non-blocking, returns LoginSession - `wait_for_login(session, timeout=...)` — blocks, raises LoginFlowError - `cancel_login(session)` — abandons cleanly - `web_login_flow(...)` now composes start + wait (existing API preserved for terminal CLI) Updated server `instructions` to tell agents NOT to pass wait=True in chat contexts and to poll whoami after the non-blocking call. Tested end-to-end via real MCP stdio client: wait=False returns in ~0.2s vs previous 60s+ timeout. Background thread persists token correctly on user submit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
You hit the exact problem: in Claude Desktop, `login_browser` always times out at ~60s because the client doesn't support `resetTimeoutOnProgress`. The server WAS doing the right thing (binding port, opening browser), but the tool call got killed before the user could submit credentials — so even on successful login, the token never came back through that call.
Fix
`login_browser` defaults to `wait=False` now:
`wait=False` (DEFAULT, recommended for Claude Desktop / Cursor chat / Continue / Cline / Zed): returns the URL in <1s. Server keeps running in a daemon thread for `timeout` seconds. When user submits, token is persisted to `config.json` + keychain in the background. Agent then polls `whoami` to detect `token_present: true`.
`wait=True` (opt-in for Claude Code / Codex CLI / any agent supporting long-running tools): blocks until complete, returns full `{email, user_id, ...}` inline. Same behavior as before.
Refactor in web_auth.py
Decomposed the previously monolithic `web_login_flow` into:
`web_login_flow` now composes these — terminal CLI (`emodul auth login --browser`) unchanged.
Verified end-to-end
Release
After merge: tag v0.1.6 → OIDC publish → `pipx upgrade emodul` → restart Claude Desktop → next login flow takes 1s, you open URL, type password, agent polls whoami.