Conversation
In the process of writing this test, I uncovered several places where there is unnecessary friction in applying the package to very simple examples. This test should be used to expand testing coverage to all options of the keyword arguments in order to find remaining bugs!
Owner
Author
|
This starts to address #13, although we should have much better coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the codebase, focusing on enhanced CI support, compatibility, and improved testing. The most significant changes are the addition of a CI workflow for multi-version Python testing, improved handling of bin types in the mass budget calculation, and new synthetic tests for the budget module.
Continuous Integration and Compatibility:
.github/workflows/ci.yml) to test across Python versions 3.11–3.14, including Conda environment setup and pytest execution.ci/environment.ymlto support Python versions >=3.11, improving compatibility with the new CI matrix.Testing Enhancements:
test_mass_budget) inxwmb/tests/test_budget.pyto validate mass budget calculations using the new bin handling.Functionality Improvements:
mass_budgetinxwmb/budget.pyto acceptxr.DataArrayas bins, enhancing flexibility in input types.Dependency and Version Updates:
xwmtdependency to version >=0.2.0 inpyproject.tomlfor improved compatibility.0.5.7inxwmb/version.py.