Skip to content

Re-apply our changes over latest main#3

Open
arkuhn wants to merge 81 commits intomasterfrom
updated-fix-recurrence-id
Open

Re-apply our changes over latest main#3
arkuhn wants to merge 81 commits intomasterfrom
updated-fix-recurrence-id

Conversation

@arkuhn
Copy link
Copy Markdown

@arkuhn arkuhn commented Mar 24, 2025

  1. Checkout a branch with latest main
  2. Re-apply our diffs one by one in order:
    • git cherry-pick a2f73c96371c27cb1106fdda5a99b637add7d482
    • git cherry-pick e47fcd68f45d236b10805f37b617b7e8f6ac5753
    • git cherry-pick 73d6e7ace88fc5c8503a15da9659828137a10047
  3. Add a new commit, switching setup.cfg to use the new format _ instead of - - this currently blocks upgrading to 3.11
error: The build backend returned an error
  Caused by: Call to `setuptools.build_meta:__legacy__.prepare_metadata_for_build_wheel` failed (exit status: 1)
[stderr]
    raise InvalidConfigError(
setuptools.errors.InvalidConfigError: Invalid dash-separated key 'description-file' in 'metadata' (setup.cfg), please use the underscore name 'description_file' instead.

hint: This usually indicates a problem with the package or the build environment.
make: *** [compile-requirements] Error 2
(venv) 
  1. Updated commit in mamba makefile:
icalendar==5.0.12
git+https://github.com/headway/icalevents.git@0b32bd0e7d47e8bf586e4eacc68cc846a4fac050#egg=icalevents==0.1.26
  1. This package now requires poetry-core to build, so I added that in our makefile:
compile-requirements: venv ## Compile requirements.in to requirements.txt
	uv pip install pip-tools==7.4.1 maturin==1.5.1 poetry-core
  1. Evidently upstream pins pytz to 2021.3, and we pin it to 2024.1...
  × No solution found when resolving dependencies:
  ╰─▶ Because only icalevents==0.1.26 is available and icalevents==0.1.26 depends on pytz==2021.3, we can conclude that all
      versions of icalevents depend on pytz==2021.3.
      And because you require pytz==2024.1 and icalevents, we can conclude that your requirements are unsatisfiable.
make: *** [compile-requirements] Error 1

I would have liked to just switch us to upstream, but seemingly the behavior still differs (upstream considers this codepath legacy though). I don't have any context on the changes, but it would be cool to write a repro tests for the behavior we added fixed and either a) get the fix(es) submitted upstream or b) switch to upstream if both packages pass the tests.

eigenmannmartin and others added 30 commits October 17, 2021 18:30
updates:
- [github.com/pre-commit/pre-commit-hooks: v2.3.0 → v4.0.1](pre-commit/pre-commit-hooks@v2.3.0...v4.0.1)
- https://gitlab.com/pycqa/flake8https://github.com/PyCQA/flake8
- [github.com/PyCQA/flake8: 3.7.9 → 4.0.1](PyCQA/flake8@3.7.9...4.0.1)
Also rename the workflow files to better match Jazzband practices.
Jazzband: Synced file(s) with jazzband/.github
fix: Template on empty/unreadable file exception is a string, not a float
Prior to 0.1.25, ics files containing events like the following worked normally.  [A change](jazzband@11dfa8c#diff-6659079db1c5e26c4bd075f64b432522644ff3ee3bd4264f2863bd6f69d63e72L287-R405) in the 11dfa8c caused these to break.  This is an ics I'm getting from Google for my scheduled lunches :)

This restores the pre-0.1.25 behavior and continues to pass all tests.

```
BEGIN:VEVENT
SUMMARY:LUNCH
DTSTART;TZID=America/Boise:20210929T130000
DTEND;TZID=America/Boise:20210929T135000
DTSTAMP:20211029T005456Z
UID:not_sure_if_this_uid_is_secret@google.com
SEQUENCE:3
RRULE:FREQ=WEEKLY;UNTIL=20211020;BYDAY=MO,TH,WE;WKST=SU
EXDATE;TZID=America/Boise:20211013T130000
CREATED:20210811T153934Z
DESCRIPTION:
LAST-MODIFIED:20210927T184338Z
LOCATION:
STATUS:CONFIRMED
TRANSP:OPAQUE
X-APPLE-TRAVEL-ADVISORY-BEHAVIOR:AUTOMATIC
BEGIN:VALARM
ACKNOWLEDGED:20210830T185450Z
ACTION:NONE
TRIGGER;VALUE=DATE-TIME:19760401T005545Z
UID:343EB08E-9C4C-4151-92D0-80B351A080B2
X-WR-ALARMUID:343EB08E-9C4C-4151-92D0-80B351A080B2
END:VALARM
END:VEVENT
```
updates:
- [github.com/psf/black: 21.9b0 → 21.10b0](psf/black@21.9b0...21.10b0)
Fix reversion of RRULE UNTIL behavior
- Set up tools has deprecated using - in favor of _
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants