Open
Conversation
…ezone issues in a generalized way for all reccuring events
added contributing.md, as required by https://jazzband.co/about/guidelines
for more information, see https://pre-commit.ci
…ay-events Reccuring all day events
merge upstream master
updates: - [github.com/pre-commit/pre-commit-hooks: v2.3.0 → v4.0.1](pre-commit/pre-commit-hooks@v2.3.0...v4.0.1) - https://gitlab.com/pycqa/flake8 → https://github.com/PyCQA/flake8 - [github.com/PyCQA/flake8: 3.7.9 → 4.0.1](PyCQA/flake8@3.7.9...4.0.1)
[pre-commit.ci] pre-commit autoupdate
Also rename the workflow files to better match Jazzband practices.
Jazzband: Synced file(s) with jazzband/.github
for more information, see https://pre-commit.ci
fix: Template on empty/unreadable file exception is a string, not a float
Prior to 0.1.25, ics files containing events like the following worked normally. [A change](jazzband@11dfa8c#diff-6659079db1c5e26c4bd075f64b432522644ff3ee3bd4264f2863bd6f69d63e72L287-R405) in the 11dfa8c caused these to break. This is an ics I'm getting from Google for my scheduled lunches :) This restores the pre-0.1.25 behavior and continues to pass all tests. ``` BEGIN:VEVENT SUMMARY:LUNCH DTSTART;TZID=America/Boise:20210929T130000 DTEND;TZID=America/Boise:20210929T135000 DTSTAMP:20211029T005456Z UID:not_sure_if_this_uid_is_secret@google.com SEQUENCE:3 RRULE:FREQ=WEEKLY;UNTIL=20211020;BYDAY=MO,TH,WE;WKST=SU EXDATE;TZID=America/Boise:20211013T130000 CREATED:20210811T153934Z DESCRIPTION: LAST-MODIFIED:20210927T184338Z LOCATION: STATUS:CONFIRMED TRANSP:OPAQUE X-APPLE-TRAVEL-ADVISORY-BEHAVIOR:AUTOMATIC BEGIN:VALARM ACKNOWLEDGED:20210830T185450Z ACTION:NONE TRIGGER;VALUE=DATE-TIME:19760401T005545Z UID:343EB08E-9C4C-4151-92D0-80B351A080B2 X-WR-ALARMUID:343EB08E-9C4C-4151-92D0-80B351A080B2 END:VALARM END:VEVENT ```
updates: - [github.com/psf/black: 21.9b0 → 21.10b0](psf/black@21.9b0...21.10b0)
[pre-commit.ci] pre-commit autoupdate
Fix reversion of RRULE UNTIL behavior
Finalize support for STATUS/URL
- Set up tools has deprecated using - in favor of _
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git cherry-pick a2f73c96371c27cb1106fdda5a99b637add7d482git cherry-pick e47fcd68f45d236b10805f37b617b7e8f6ac5753git cherry-pick 73d6e7ace88fc5c8503a15da9659828137a10047setup.cfgto use the new format_instead of-- this currently blocks upgrading to3.11poetry-coreto build, so I added that in our makefile:2021.3, and we pin it to2024.1...I would have liked to just switch us to upstream, but seemingly the behavior still differs (upstream considers this codepath legacy though). I don't have any context on the changes, but it would be cool to write a repro tests for the behavior we added fixed and either a) get the fix(es) submitted upstream or b) switch to upstream if both packages pass the tests.