Store image meta data in arrays and adds unit tests#43
Open
achingbrain wants to merge 1 commit intoheapsource:masterfrom
achingbrain:master
Open
Store image meta data in arrays and adds unit tests#43achingbrain wants to merge 1 commit intoheapsource:masterfrom achingbrain:master
achingbrain wants to merge 1 commit intoheapsource:masterfrom
achingbrain:master
Conversation
|
is this patch added to Master ? |
Author
|
No, this pull request has not been merged. If you like, check out mongoose-crate - it works along similar lines to mongoose-attachments and supports arrays of images among other things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does a number of things (sorry):
To run the unit tests, do:
Then open coverage/lcov-report/index.html to see code coverage.
There was an existing test that looks at the output of ImageMagick to verify whether support for certain formats was enabled. I'd argue that this test should be removed as it's not testing mongoose-attachments code, rather an external dependency so can break due to circumstances out of our control, but I've converted it into a mocha unit test anyway pending further discussion.