Skip to content

User exists? instead of find_first #5169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dijkztra wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

User exists? instead of find_first #5169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cdccaa
User exists? instead of find_first
Dijkztra Nov 29, 2019
61a2615
remove orm_adapter
Dijkztra Nov 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/devise/models/rememberable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def serialize_from_cookie(*args)
def remember_token #:nodoc:
loop do
token = Devise.friendly_token
break token unless to_adapter.find_first({ remember_token: token })
break token unless exists?({ remember_token: token })
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/devise/token_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def generate(klass, column)
loop do
raw = Devise.friendly_token
enc = OpenSSL::HMAC.hexdigest(@digest, key, raw)
break [raw, enc] unless klass.to_adapter.find_first({ column => enc })
break [raw, enc] unless klass.exists?({ column => enc })
Copy link
Copy Markdown

@gabrielbaldao gabrielbaldao Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the another change you was using { key: value } and now { key => value }, what do you think about use one as default, I suggest { key: value }

end
end

Expand Down