Conversation
|
Thanks for the PR! Can you remind me of what the original problem was? I think this solution isn't great, ideally we don't want to force the user to muck with their environment. If anything, we could just namespace HOST (so s/HOST/ONYX_HOST/g). |
OpenSUSE's /etc/profile sets HOST to $(hostname), and this overrides HOST in Makefile and breaks the build. Namespacing is a good option indeed |
Can you test this patch? I think unconditionally setting HOST is an okay, minimally invasive solution. It's not like we actively lose anything, it'll still be set with regard to |
|
@petershh do you still run OpenSUSE? Wondering if you could check that last patch so we can merge a final solution. Thanks! |
That patch indeed works. Sorry for not checking on time. |
No description provided.