Non-IFD Nix Integration#314
Open
mara-schulke wants to merge 2 commits into
Open
Conversation
mara-schulke
added
complexity::low
ulucs
reviewed
Jun 8, 2026
| lock = builtins.fromTOML (builtins.readFile lockfile); | ||
| packages = lock.packages or [ ]; | ||
|
|
||
| fileUrl = pkg: |
Contributor
There was a problem hiding this comment.
this feels a bit unstable with regards to having to keep the logic in here and inside the rust code in sync at all times. What if we had:
- a buffrs command that downloaded a single dependency (so the hash can be reused for the fixed-output derivation)
- a buffrs command that merges the outputs of above derivations into a cache folder
that way, the whole cache folder logic stays inside the rust binary; and can be changed without breaking things for users
Contributor
There was a problem hiding this comment.
maybe we would be better off just having a test that this approach matches the rust behaviour?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds a non-IFD variant of the
cache.nixwhich circumvents frequent rebuilding and performance bottlenecks on buffrs in nix. Reference on IFD: https://nix.dev/manual/nix/2.26/language/import-from-derivation