refactor: typed component configuration and registration flow#620
Draft
Copilot wants to merge 2 commits intorefactor/components-use-php-config-filesfrom
Draft
refactor: typed component configuration and registration flow#620Copilot wants to merge 2 commits intorefactor/components-use-php-config-filesfrom
Copilot wants to merge 2 commits intorefactor/components-use-php-config-filesfrom
Conversation
Co-authored-by: sebastianthulin <797129+sebastianthulin@users.noreply.github.com>
|
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor component configuration variable naming and interface
refactor: typed component configuration and registration flow
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Component configs needed clearer naming, a common interface with explicit getters, singleton instances, setter-based inputs, and stricter typing across registration.
ComponentConfigurationInterfacedefining getters for slug/name/identifier/view/default parameters/types/descriptions/dependencies plus a setter for inputs.ComponentConfigurationto wrap PHP config arrays into per-slug singletons with typed accessors and guarded input mutation.Registerto consume configuration objects via getters, renamed parameter types for clarity, strengthened type validation, and improved error messaging for view data/config loading.dependencykey via deprecated handling while preferringdependencies; tightened signatures and casting to maintain expected shapes.Example:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.