Ds 2171 introduce singleJobPerResourcePolicy and extend JobAdminApi with dynamic scheduler configuration#1823
Conversation
qGYdXbY2
approved these changes
Apr 29, 2026
mchrza
changed the title
mujammil10
reviewed
May 6, 2026
| @@ -334,13 +354,79 @@ private static Step cancelNonRunningStep(Job job, Step step) { | |||
| private Future<Boolean> mayExecute(Job job) { | |||
| //Check execution policies and resources | |||
| return executionPoliciesSatisfied(job) | |||
Contributor
There was a problem hiding this comment.
The checks for executionPoliciesSatisfied and singleJobPerResourceSatisfied can be done parallely and result can be checked in single .compose
Contributor
There was a problem hiding this comment.
Also both of these calls are loading the list of RUNNING jobs as first step. Maybe instead we should load that list once upfront and pass it to both of these methods (as these are private anyways).
roegi
requested changes
May 19, 2026
| @@ -334,13 +354,79 @@ private static Step cancelNonRunningStep(Job job, Step step) { | |||
| private Future<Boolean> mayExecute(Job job) { | |||
| //Check execution policies and resources | |||
| return executionPoliciesSatisfied(job) | |||
Contributor
There was a problem hiding this comment.
Also both of these calls are loading the list of RUNNING jobs as first step. Maybe instead we should load that list once upfront and pass it to both of these methods (as these are private anyways).
…orce FIFO for pending jobs on overlapping resources. Signed-off-by: mchrza <maximilian.chrzan@here.com>
… control/configure scheduler during runtime. Signed-off-by: mchrza <maximilian.chrzan@here.com>
…hedulerState in JobExecutor. SchedulerRuntimeState can be now RUNNING/PAUSED. Further small optimizations. Signed-off-by: mchrza <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
…rt for partial state updates. Signed-off-by: mchrza <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
roegi
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JobExecutor:
JobAdminApi: