feat(icons): add acf partial and basic styles for icons#2
Open
giuseppe-hex wants to merge 1 commit intomainfrom
Open
feat(icons): add acf partial and basic styles for icons#2giuseppe-hex wants to merge 1 commit intomainfrom
giuseppe-hex wants to merge 1 commit intomainfrom
Conversation
Member
|
nice |
Jamiewarb
approved these changes
Jul 6, 2024
Comment on lines
+1
to
+17
| .c-icon { | ||
| &--up { | ||
| tranform: rotate(0); | ||
| } | ||
|
|
||
| &--right { | ||
| transform: rotate(45deg); | ||
| } | ||
|
|
||
| &--down { | ||
| transform: rotate(180deg); | ||
| } | ||
|
|
||
| &--left { | ||
| transform: rotate(270deg); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Do we need these classes or can we just use tailwind?
e.g. u-rotate-45
Contributor
Author
There was a problem hiding this comment.
We can, I'm just being verbose/OCD about naming 😅 I'll remove.
Jamiewarb
approved these changes
Jul 6, 2024
| protected function getIcons(): array | ||
| { | ||
| $filesystem = new Filesystem(); | ||
| $files = $filesystem->allFiles(get_template_directory() . '/resources/images/icons'); |
Member
There was a problem hiding this comment.
Would it make sense to use a Bloom config, and set this in there?
I can foresee an easier time updating repositories in future as Bloom evolves if we have per-app configuration for this, rather than putting it in separate files.
We have a config directory already, is it possible to use that?
Contributor
Author
There was a problem hiding this comment.
@Jamiewarb Are you referring to the file path specifically? If so, yeah that makes sense 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module adds an ACF partial which can be added to any ACF block. It displays a select list populated by all files in the
resources/images/iconsdirectory:or