Fix auto-detect outcomes missing corrected trades + silent failure#62
Merged
Conversation
Two bugs in autoDetectOutcomes flow: 1. syncRysk corrected path (OPEN→EXPIRED for already-synced trades) never fed into autoDetectOutcomes, so re-synced expired options were never upgraded to CALLED/ASSIGNED 2. CoinGecko price lookup failures were silent — outcome stayed EXPIRED with no user-facing signal to check manually Fix: collect correctedTrades alongside expiredNew before calling autoDetectOutcomes; toast when price lookup returns null. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in autoDetectOutcomes flow:
Fix: collect correctedTrades alongside expiredNew before calling autoDetectOutcomes; toast when price lookup returns null.