Draft
Conversation
…gic behind main, distant and shunting light signals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I updated the rendering of Czech signals a bit.
There will definitely be further changes (especially concerning speed_limit signals), but this would be great to get online.
I can add images of what's changed with localhost preview links if necessary.
Here's a summary of what's changed:
Organized the icons into folders per signal type (e.g. the part after
CZ-D1:)For consistency, the descriptions of signals are now always in Czech
Reworked icons and the logic behind choosing icons of combined/main light signals, distant light and shunting light signals.
They now reflect the logic of 'display the most restrictive aspect except danger' (with the exception of auto-block signals, but this might get changed with the introduction of traversable). Also based on which states the signal can show, the most appropriate number of light bulbs is approximated.
Updated icons:
resetting_switchis now differentiated by yellow outline, commonly used on this type of signal for better visibilityCZ-D1:stujrectangle sign now has the same dimensions as all the other rectangular signsCZ-D1:posun_zakazansimplified svgCZ-D1:navestidlo_vykolejkyadded a black square background, for differentiation fromposun_zakazanCZ-D1:predvestnik_nsremoved the 0 at the ones place - not actually there on speed_limit_distant signalsCZ-D1:predvestnik_ns+speed=noneis now supported. (Konec platnosti rychlostníků NS)Added support for shortened
speed_limit_distantsigns.Added rendering of distant sign
CZ-D1:tabulka_s_krizem(just added the entry into.yaml, icons were ready)Added support for newly established tag
station_distant=CZ-D1:stanoviste_samostatne_predvesti. (Describes the board under distant light signals)Removed
CZ-D1:serazovaci_navestidloin favor ofCZ-D1:seradovaci_navestidlo(all signals have been rettaged already)Partially changed the visualization of
hlavni_navestidlospeed_limits to better reflect reality in most cases. Proper visualization of all possiblities needs better tagging.Updated visualizations to recognize as many of HaPe-CZs signals as possible such as when
refis unknown and replaced by '_' or similar cases. However, for these signals only the basic signal icon is displayed, no differentiation based onstatesorminor:functionis done. This is a partial regression in functionality, but it keeps the .yaml clean*-ish*. By far the majority of recognized signals are shunting light signals and those do not require any differentiation.