Skip to content

another sample of use to README file#7

Open
mihaj wants to merge 3 commits into
highbyte:masterfrom
mihaj:master
Open

another sample of use to README file#7
mihaj wants to merge 3 commits into
highbyte:masterfrom
mihaj:master

Conversation

@mihaj

@mihaj mihaj commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

I am adding an additional sample, which I use. If you like it accept it :).

@mihaj

mihaj commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

Dockerfile needs some testing IMO. Let me know if you would like to do it differently. I've tried the 5.0 base image, and there are some issues with installing JDK. I can look into it tomorrow.

@mihaj

mihaj commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

I've removed the a Dockerfile changes since someone else will PR those changes.

@highbyte

Copy link
Copy Markdown
Owner

Thanks for example. Probably not a bade idea to have a complete example.
Before I'll add anything I'll look into the differences between the test arguments in your example and mine.

I use the following packages related to testing

  Microsoft.NET.Test.Sdk
  xunit
  xunit.runner.visualstudio
  coverlet.collector

and use the test arguments
--logger trx --collect:"XPlat Code Coverage" -- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover

While you have these test packages (+ others like xunit or nunit?)

  coverlet.msbuild
  coverlet.collector

and use the test arguments
/p:CollectCoverage=true /p:CoverletOutputFormat=opencover

Probably achieves same thing in different ways.

@mihaj

mihaj commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

I use xUnit yes. I do not collect any TRX files, just run the tests, and measure the coverage. Only coverage percentages are shown in the Sonarqube.

But I'll try to import TRX to Sonarqube by combining it with your example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants