Test3laser#251
Merged
Merged
Conversation
To adopt this PR to popup again, you need: - to change -> "const targetDoc = popupWindow?.document || document;" (at two places whare "const targetDoc = document"; is writted) - to add-> "popupWindow" at the ends of two React.useEffect()s which defines "const targetDoc" (same functions above)
More simple implementation, although the values are slightly different from the values taken from the 'translate' value of the finally rendered HTML.
With this change, the viewer's laser will be created every time as the page changes. Is there any better implementation???
Draw menu under the React architecture, not by directly drawing DOM.
Draw menu under the React architecture, not by directly drawing DOM. Here, moving styles to styles.js
cursorEl is not necessary more.
It is included in ...coordinates.
1) Showing laser pointer when the presenter uses mobile devices, which did not show anything previously. But the laser pointer does not respond very quickly because here the clients's information is recruited, not directly reflecting the presenter's touch. 2) Now the presenter can show the pull down menu to select laser.
- Store the cursor position - Show Laser as a React element using the stored cursor position - Change the class name to avoid being removed by removeViewerLaser().
🚨 Automated tests failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes Issue(s)
Closes #
Motivation
How to test
More