feat: Build hitpay app for cal.com by MuhammadAimanSulaiman · Pull Request #1 · hit-pay/cal.com

MuhammadAimanSulaiman · 2024-10-01T13:40:05Z

Adding hitpay functions to hitpay app

kutsaniuk · 2024-10-01T20:46:08Z

packages/app-store/hitpay/api/add.ts

+// import { createDefaultInstallation } from "@calcom/app-store/_utils/installation";
+// import type { AppDeclarativeHandler } from "@calcom/types/AppHandler";
+// import appConfig from "../config.json";
+// const handler: AppDeclarativeHandler = {
+//   appType: appConfig.type,
+//   variant: appConfig.variant,
+//   slug: appConfig.slug,
+//   supportsMultipleInstalls: false,
+//   handlerType: "add",
+//   createCredential: ({ appType, user, slug, teamId }) =>
+//     createDefaultInstallation({ appType, user: user, slug, key: {}, teamId }),
+// };
+// export default handler;


Hi @MuhammadAimanSulaiman, please remove.

kutsaniuk · 2024-10-01T20:46:34Z

packages/app-store/hitpay/api/callback.ts

@@ -0,0 +1,39 @@
+// import type { Prisma } from "@prisma/client";


Please, remove it.

I removed it

kutsaniuk · 2024-10-01T20:48:01Z

packages/app-store/hitpay/api/webhook.ts

@@ -0,0 +1,61 @@
+import type { NextApiRequest, NextApiResponse } from "next";
+// import getRawBody from "raw-body";


Please, remove.

kutsaniuk · 2024-10-01T20:51:48Z

packages/app-store/hitpay/lib/PaymentService.ts

+    bookerName: string,
+    paymentOption: PaymentOption,
+    bookerEmail: string
+    // bookerPhoneNumber?: string | null,


Please, remove unused code.

I deleted all unused code

kutsaniuk · 2024-10-07T03:32:04Z

packages/app-store/hitpay/zod.ts

+  value: z.string(),
+});
+
+export const paymentOptionsSchema = z.array(paymentOptionSchema);


If we don't need paymentOptionsSchema, please remove it.

I removed it

kutsaniuk · 2024-10-07T03:32:51Z

packages/app-store/hitpay/static/1.jpeg

Remove unused images

The images are for the description on cal app store.
We shouldn't remove them and should replace them with ones related to hitpay.

kutsaniuk · 2024-10-07T03:34:24Z

packages/app-store/hitpay/pages/setup/index.tsx

+  saltKey: string | null;
+}
+
+export interface IHitPayWebhookEventReturn {


Remove unused interface IHitPayWebhookEventReturn

I removed it

kutsaniuk · 2024-10-07T03:47:40Z

packages/app-store/hitpay/components/HitpayPaymentComponent.tsx

+import { useEffect } from "react";
+import { z } from "zod";
+
+// import type { PaymentPageProps } from "@calcom/features/ee/payments/pages/payment";


Remove it, please

kutsaniuk · 2024-10-07T03:47:52Z

packages/app-store/hitpay/components/HitpayPaymentComponent.tsx

+    // Will be parsed on render
+    data: unknown;
+  };
+  // paymentPageProps: PaymentPageProps;


Remove it, please

kutsaniuk · 2024-10-07T03:48:34Z

packages/app-store/hitpay/components/HitpayPaymentComponent.tsx

+
+export const HitpayPaymentComponent = (props: IPaymentComponentProps) => {
+  const { payment } = props;
+  console.log("HitpayPaymentComponent payment prop =>", payment);


Remove it, please

I removed it

kutsaniuk · 2024-10-07T03:51:21Z

packages/app-store/hitpay/components/EventTypeAppSettingsInterface.tsx

+import { useLocale } from "@calcom/lib/hooks/useLocale";
+import { Alert, Select, TextField } from "@calcom/ui";
+
+import { paymentOptions } from "../lib/constants";


Change with import { paymentOptions } from "../lib";

I changed it

kutsaniuk · 2024-10-07T03:52:13Z

packages/app-store/hitpay/components/EventTypeAppCardInterface.tsx

+  const { getAppData, setAppData, disabled } = useAppContextWithSchema<typeof appDataSchema>();
+  const { enabled, updateEnabled } = useIsAppEnabled(app);
+  const otherPaymentAppEnabled = checkForMultiplePaymentApps(eventTypeFormMetadata);
+  const [requirePayment, setRequirePayment] = useState(getAppData("enabled"));


Remove setRequirePayment if we don't need it.

github-actions · 2024-10-23T02:34:56Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Integrating hitpay functions to hitpay app". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

calcom#18416) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

* global-error is not needed * remove /403 and /500 pages from pages router * add 403 and 500 pages in App Router * add i18n strings * fix i18n string * fix styling

…y undetected before) (calcom#18432)

…rocess (calcom#18429) - Introduced a new `DryRunMessage` component to inform users when in dry run mode. - Implemented utility function `isBookingDryRun` to check for dry run status based on URL search parameters. - Updated the `Booker` component to conditionally render the dry run message. - Adjusted booking mutation input mapping to reuse the utility Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

* migrate icons page * migrate main index page * remove /icons page * use i18n string * fix imports * add icons_showcase i18n string * add /app dir to tailwind preset config * use classname * do not migrate main index page

* feat: apply full width automatically for DataTable * change implementation * load all columns of insights routing table at the same time * update team member list * sticky columns for >= sm * fix type error --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

* chore: sync with main * feat: update translations via @replexica --------- Co-authored-by: Replexica <support@replexica.com>

* fix: get bookings ordering * chore: update query * chore: add log for debuggin on prod * chore

…dy in view on mount (calcom#18446)

* fix: Zoho Bigin not pulling information from booking * update * missed * fix contactcreation

* feat: Enhance SCIM user attribute handling and sync process - Introduced a new PR_TODO.md file to track ongoing tasks and fixes. - Updated `getAttributesFromScimPayload` to accept a directoryId and ignore core user attributes during syncing. - Modified `handleUserEvents` to pass directoryId when syncing custom attributes. - Improved attribute creation logic to handle unique options and added support for optional isGroup property in attribute options. - Added utility function `getOptionsWithValidContains` to ensure valid sub-options in attribute options. - Updated tests to reflect changes in attribute handling and ensure proper functionality. This commit addresses issues with user attribute syncing and enhances the overall attribute management process. * test: Add unit tests for getOptionsWithValidContains utility function - Introduced a new test file for the getOptionsWithValidContains function. - Added tests to verify the removal of duplicate options, initialization of empty contains arrays, filtering of non-existent sub-options, and handling of empty options arrays. - Ensured comprehensive coverage of the utility's functionality to enhance reliability and maintainability.

…8576)

…ore (calcom#18579) Co-authored-by: Peer Richelsen <peeroke@gmail.com>

Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

* fix: improve filters at /bookings * fix type

* chore: skip failure e2e test * Update .env * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update .env * Update manage-booking-questions.e2e.ts * fix * fix flake * Update saml.e2e.ts

* Update mint.json * fix broken links --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>

* feat: added pagination to platform managed users table * removed console * implemented feedback, removed unused components * added label * Update managed-users-view.tsx * Update managed-users-view.tsx

Co-authored-by: Replexica <support@replexica.com>

* new granola app * granola app

* fix: wrong Meeting Ended payload in zapier * fix

* Create dub links if valid * Map through filtered links --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>

* Fix error * remove indent --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>

Co-authored-by: Omar López <zomars@me.com>

* chore: apps/[slug] remove pages router * remove apps/[slug] pages from /future * chore: apps/installed remove pages router * chore: apps/installation remove pages router * remove Head element * fix metadata * fix test * fix another test * chore: apps/categories remove pages router * revert unneeded changes * update middleware * Remove <Head> * remove unused import and code * remove unused import and code again * fix * fix category page * add split icon * add /routing paths to middleware matcher * wip * remove HeadSeo from App.tsx * clean up head-seo test * add generateAppMetadata * use generateAppMetadata in apps/[slug] page * delete file * remove log * fix * fix * fix apps/installed pages * fix cateogires pages * fix * fix imports * wip * fix * fix * fix metadata * fix * redirect /apps/routing-forms to /routing * replace all usages of /apps/routing-forms to /routing * better naming * /routing -> /routing/forms * fix * fix * fix * fix * remove backPath as it is irrelevant when withoutMain is true * fix type checks * fix type check in apps/[slug] * refactors * fix * fix test * fix * fix * fix * Replace multiple leading slashes with a single slash * migrate routing-forms too * add re routing * fix * add redirection --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>

* wip * wip * fix not found page * render middleware for /settings pages * fix * remove global-error page * add metadata to not-found page * make not-found page static * remove 404 * adding not-found to middleware is not necessary * add every routes to config.matcher * fix test * fix style * use i18n string * fix tests * fix * fix * revert unneeded changes * fix * fix * fix * fix style * fix * remove 404 * remove log * fix * fix * fix * fix * better naming * parallel testing --------- Co-authored-by: Benny Joo <sldisek783@gmail.com>

…ages/_error` (calcom#18606) * remove page/_error * refactor app/error

…dling (calcom#18615) * fix lint error * fix booking page and better error handling

* chore: decouple calcom/ui from atoms #1 * recover input from main * fix: vite config dialog

kutsaniuk reviewed Oct 1, 2024

View reviewed changes

MuhammadAimanSulaiman force-pushed the hitpay-app branch from d49034b to 3671c85 Compare October 7, 2024 02:54

kutsaniuk reviewed Oct 7, 2024

View reviewed changes

MuhammadAimanSulaiman force-pushed the hitpay-app branch 3 times, most recently from 684f5ac to 3bd6e64 Compare October 9, 2024 07:24

MuhammadAimanSulaiman force-pushed the hitpay-app branch from f37c734 to ccdecba Compare October 23, 2024 02:34

MuhammadAimanSulaiman changed the title ~~Integrating hitpay functions to hitpay app~~ feat: Build hitpay app for cal.com Oct 23, 2024

MuhammadAimanSulaiman force-pushed the hitpay-app branch 2 times, most recently from d625967 to effe6c5 Compare October 23, 2024 12:08

github-actions bot added ❗️ migrations ❗️ .env changes labels Dec 6, 2024

kutsaniuk force-pushed the hitpay-app branch from 157e261 to c01d754 Compare December 6, 2024 06:51

cnhhoang850 and others added 16 commits January 10, 2025 16:55

Fix duplicated data returned by Prisma query in team availability view (

ae485b4

calcom#18416) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

chore: Migrate /403 and /500 pages to App Router (calcom#18424)

777d7ef

* global-error is not needed * remove /403 and /500 pages from pages router * add 403 and 500 pages in App Router * add i18n strings * fix i18n string * fix styling

fix: Some recently discovered type errors breaking build (not sure wh…

a30deb0

…y undetected before) (calcom#18432)

fix: Add to google leads to a 403 page (calcom#18430)

4ec1094

fix: atoms globals.css invalid class format (calcom#18295)

17457fd

chore: migrate /icons page to App Router (calcom#18436)

47f55c7

* migrate icons page * migrate main index page * remove /icons page * use i18n string * fix imports * add icons_showcase i18n string * add /app dir to tailwind preset config * use classname * do not migrate main index page

fix: booker atom booking fields (calcom#18441)

7089043

feat: update translations via @replexica (calcom#18438)

b74cf21

* chore: sync with main * feat: update translations via @replexica --------- Co-authored-by: Replexica <support@replexica.com>

fix: get bookings ordering (calcom#18439)

3038385

* fix: get bookings ordering * chore: update query * chore: add log for debuggin on prod * chore

fix: improve useInViewObserver hook to trigger when observer is alrea…

efd999f

…dy in view on mount (calcom#18446)

fix: react incompatiblity with nextjs error (calcom#18433)

00b6e28

fix: Zoho Bigin not pulling information from booking (calcom#18445)

68efbcd

* fix: Zoho Bigin not pulling information from booking * update * missed * fix contactcreation

fix: resolve atoms build error

734cb4b

anikdhabal and others added 27 commits February 24, 2025 11:28

fix: wip (calcom#18574)

90c7b9a

cleanup: remove-headseo-from-migrated-app-router-components (calcom#1…

10e8b04

…8576)

chore: fix SVG warning on render (calcom#18572)

27f5dd7

fix: date filter for the same day showing appointments of the day bef…

2a03529

…ore (calcom#18579) Co-authored-by: Peer Richelsen <peeroke@gmail.com>

fix: billing plain chat working (calcom#18530)

848314e

fix: unpublished org is visble as an option in workflow (calcom#18522)

6ddd919

Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

fix: improve filters at /bookings (calcom#18581)

4f71dac

* fix: improve filters at /bookings * fix type

docs: fix footer socials in /help and other broken pages (calcom#18578)

be88311

* Update mint.json * fix broken links --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>

fix: broken platform members table (calcom#18583)

91865f5

feat: added pagination to platform managed users table (calcom#18523)

460009b

* feat: added pagination to platform managed users table * removed console * implemented feedback, removed unused components * added label * Update managed-users-view.tsx * Update managed-users-view.tsx

feat: update translations via @replexica (calcom#18584)

837ee34

Co-authored-by: Replexica <support@replexica.com>

chore: improve ooo reason documentation apiv2 (calcom#18582)

5e8aa24

chore: release v4.8.16

1cad7d0

feat: granola.ai app (calcom#18585)

9c6162a

* new granola app * granola app

fix: wrong Meeting Ended payload in zapier (calcom#18202)

c26b960

* fix: wrong Meeting Ended payload in zapier * fix

fix: Create dub links if valid url (calcom#18588)

f3a97fc

* Create dub links if valid * Map through filtered links --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>

docs: fix error introduced in calcom#18578 (calcom#18593)

ef57a11

* Fix error * remove indent --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>

feat: Round Robin weights future members toggle (calcom#17782)

e2c24de

Co-authored-by: Omar López <zomars@me.com>

detailed customer card (calcom#18511)

24ba9a2

Co-authored-by: Omar López <zomars@me.com>

feat: render custom error page for unexpected sever error + remove` p…

982f272

…ages/_error` (calcom#18606) * remove page/_error * refactor app/error

fix: app/not-found cannot be a static page (calcom#18610)

1bc450d

Async False (calcom#18611)

0378687

chore: redirect to /500 if pathname does not exist + better error han…

d1683be

…dling (calcom#18615) * fix lint error * fix booking page and better error handling

refactor: update hitpay app description

45876b5

MuhammadAimanSulaiman force-pushed the hitpay-app branch from 0ecbfe6 to 45876b5 Compare February 24, 2025 10:25

MuhammadAimanSulaiman closed this Feb 25, 2025

MuhammadAimanSulaiman pushed a commit that referenced this pull request Mar 17, 2025

chore: decouple calcom/ui/Tooltip from atoms (calcom#19798)

b3e344d

* chore: decouple calcom/ui from atoms #1 * recover input from main * fix: vite config dialog

		@@ -0,0 +1,39 @@
		// import type { Prisma } from "@prisma/client";

		@@ -0,0 +1,61 @@
		import type { NextApiRequest, NextApiResponse } from "next";
		// import getRawBody from "raw-body";

Conversation

MuhammadAimanSulaiman commented Oct 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MuhammadAimanSulaiman Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

MuhammadAimanSulaiman Oct 7, 2024 •

edited

Loading