feat: Sprint 3 — request_id in all responses, POST /qa, POST /diff, 22 pagination tests#67
Merged
Merged
Conversation
…point, pagination tests ## Changes ### Request ID in every response - ScreenMuseServer: added `currentReqID` property, set before each dispatch - sendResponse() injects `"request_id"` into every JSON body automatically - Zero callsite changes — threaded via single choke point ### POST /qa (new endpoint) - Full QA analysis via HTTP API on any two video files - Returns complete QAReport (5 checks, confidence score, before/after) - Optional `save` param (default true) persists qa-report.json to disk - Documented in OpenAPISpec + APITypes.swift (QARequest) ### POST /diff (new endpoint) - Lightweight structural diff: metadata for file A + B + computed deltas - Returns resolution_changed, fps_changed, codec_changed booleans - No quality checks — faster than /qa when you just need the numbers - Documented in OpenAPISpec + APITypes.swift (DiffRequest, DiffResponse) ### Baseline QA for no-effects recordings - RecordViewModel: when recording without effects, ffprobe validity check runs in background; notifyError() called if output is corrupted ### Tests (22 new) - RecordingsPaginationTests.swift: full coverage of limit/offset/sort/hasMore logic including edge cases and full multi-page traversal consistency test ### Docs - CHANGELOG.md: Sprint 3 entry - BACKLOG.md: pagination tests marked done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint 3 changes: request_id in every response, POST /qa endpoint, POST /diff endpoint, baseline QA for no-effects recordings, 22 pagination tests.