Skip to content

Fix mixin order#8

Open
cjwatson wants to merge 1 commit intoholgern:mainfrom
cjwatson:scikit-learn-1.6
Open

Fix mixin order#8
cjwatson wants to merge 1 commit intoholgern:mainfrom
cjwatson:scikit-learn-1.6

Conversation

@cjwatson
Copy link

scikit-learn >= 1.6 is pickier about this.

  • Pre-Commit tests passed
  • Unit tests added / passed
  • Added doc/whats_new entry

scikit-learn >= 1.6 is pickier about this.
@olegzaikin
Copy link

@cjwatson thank you for this pull request!
It finally helped me forcing sckit-optimize work with the BRPT estimator.
By the way, I also replaced
is_present_mask = np.in1d(std_quantiles, self.quantiles)
by
is_present_mask = np.isin(std_quantiles, self.quantiles)
in the file scikit-optimize/skopt/learning/gbrt.py
Otherwise my script crashed with

'AttributeError: module 'numpy' has no attribute 'in1d'. Did you mean: 'int16'?'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants