Fix tox.ini lint target#23359
Merged
Merged
Conversation
tox fails due to being unable to reference the `script` module when trying to run `script/gen_requirements_all.py`. Instead it needs to be run as a module.
Contributor
Author
|
@MartinHjelmare FYI |
balloob
reviewed
Apr 25, 2019
| -r{toxinidir}/requirements_test.txt | ||
| commands = | ||
| python script/gen_requirements_all.py validate | ||
| python -m script.gen_requirements_all validate |
Member
There was a problem hiding this comment.
Ah, this is probably because of importing things from hassfest.
balloob
approved these changes
Apr 25, 2019
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox fails due to being unable to reference the
scriptmodule whentrying to run
script/gen_requirements_all.py. Instead it needs to berun as a module.
This was found while I was debugging #20197
Checklist:
tox. Your PR cannot be merged unless tests pass