chore(deps): fix CI build for private modules#7
Merged
Merged
Conversation
bump kit v0.4.0-alpha.7 -> alpha.9 (drops private hop.top/uri, adopts public hop.top/cite). drop machine-local replace directives (rux/stem unused; wsm repointed to module version). add private-module auth to ci.yml (GOPRIVATE + token insteadOf rewrite) mirroring aps.
replace deprecated GH_RELEASE_PLEASE_PAT with create-github-app-token (release-bot App); add workflow_dispatch; bump action v4 -> v5. clears hop-top/.github preflight conformance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI
go-buildhas been failing onmain(and therefore every PR) because the build cannot resolve private hop.top modules. Two independent causes, both fixed here.Causes
replacedirectives committed ingo.mod—hop.top/wsm,hop.top/rux,hop.top/stempointed at/Users/...paths that don't exist on the runner.ruxandstemwere also dangling (not imported, not required).ci.yml—hop-top/wsmandhop-top/uriare private repos; thego-buildjob had no token orGOPRIVATE, so the runner couldn't fetch them over HTTPS.Changes
go.mod— bumphop.top/kitv0.4.0-alpha.7 → v0.4.0-alpha.9, which drops the private (and now-deprecated)hop.top/uriin favour of the publichop.top/cite v0.1.0. Remove the three localreplacedirectives;wsm(the one genuinely imported) is repointed to its module pseudo-version.charm.land/fantasyredirect retained.ci.yml— add a "configure private modules" step (git insteadOfwithGITHUB_TOKEN) andGOPRIVATE: hop.topon the go steps, mirroringhop-top/aps(whose CI is green).Verification (local)
go build ./...,go vet ./...,go test ./...all green — includingtests/e2e.foo,foo-scrape,foo-youtube) smoke-tested — help groups,--version, and the--ext-infodiscovery contract all intact.Why this first
The three CLI-parity PRs (#4, #5, #6) build clean locally but inherit this red pipeline. Landing this unblocks them; they'll be rebased onto green
mainand merged after.