fix(activesync): harden error handler against missing collection data#16
Merged
Merged
Conversation
Make the error handler bullet proof against missing details. This fixes a user-reported 'Undefined array key' errors when _handleError() is called with incomplete collection arrays during early protocol parsing failures.
Member
|
This is probably okay, but there are two things I would like to better understand - why synckey checked against '0' (just need to look where it is coming from), and why we set class to 'Email' if it is not set? It is hard to trigger those errors, as they probably happen only with broken clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the error handler bullet proof against missing details.
This fixes a user-reported 'Undefined array key' errors when _handleError() is called with incomplete collection arrays during early protocol parsing failures.
I am going to merge this one myself but I have a few other ones which I want reviewed properly.