fix(activesync): handle missing synckey in error handler#17
Closed
ralflang wants to merge 1 commit into
Closed
Conversation
Treat missing synckey as requiring state reset (like initial sync). Asking for state reset may be wasteful but from what I read it's safe to do mostly. In EAS protocol, synckey '0' means initial sync. Missing synckey is fishy. It indicates a protocol error that occurred before synckey was parsed. Trigger synckey reset to establish a new valid state. See also: MS-ASCMD synckey semantics for initial vs subsequent sync
Member
Author
|
Closing: This change is already included in commit 07454f8 which was merged to FRAMEWORK_6_0. The comprehensive fix includes all error handler hardening changes (synckey, ID, class, and logging). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat missing synckey as requiring state reset (like initial sync).
Asking for state reset may be wasteful but from what I read it's safe to do mostly.
In EAS protocol, synckey '0' means initial sync. Missing synckey is fishy.
It indicates a protocol error that occurred before synckey was parsed.
Trigger synckey reset to establish a new valid state.
See also: MS-ASCMD synckey semantics for initial vs subsequent sync