feat/issue core 67 modern serialization#21
Merged
TDannhauer merged 8 commits intoMar 31, 2026
Conversation
… Folder classes See issue horde/Core#67 at url horde/Core#67 Implement the PHP 8.1 __serialize/__unserialize successor to the Serializable interface. Keep full BC, don't drop methods or interface right now. Needs discussion, do not merge without approval of @amulet1
Less log spam in PHP 8.2 and above.
Member
|
As I mentioned earlier, I had commits already in my fork, just did not have time to submit a PR. If you want to implement your own fixes, I will refrain from posting my commits: git logcommit 2c110a1 (HEAD -> FRAMEWORK_6_0) commit 6b7c742 commit 6397631 |
amulet1
reviewed
Mar 22, 2026
amulet1
reviewed
Mar 22, 2026
| $decoded = @unserialize($data); | ||
| if (!is_array($decoded) || empty($decoded['v']) || $decoded['v'] != 1) { | ||
| throw new Horde_ActiveSync_Exception_StaleState('Cache version change'); | ||
| } |
Member
There was a problem hiding this comment.
The version 1 older data is not going to work (__unserialize will throw an exception) unless you add
$decoded['v'] = self::VERSION;
This was already in my version.
Member
Author
|
I'd like to use your commits but I can't view them. |
Also apply discussed fix to comments.
…mmits I cannot read.
TDannhauer
approved these changes
Mar 31, 2026
Contributor
TDannhauer
left a comment
TDannhauer
left a comment
There was a problem hiding this comment.
tested in my local installation
ralflang
added a commit
that referenced
this pull request
Apr 8, 2026
Release version 3.0.0-beta2 fix: Replace deprecated call with explicit factory call. Refactor unserialize calls to use _unserializeState Add VERSION_SIXTEENONE constant for version 16.1 Merge pull request #22 from horde/feat/EAS_version_handling_per_user_or_device refactor: Remove the extra logic - this is now handled in Horde_Core_ActiveSync_Driver->getUser() directly. refactor: See also horde/Core#75 - Keep the horde specific stuff in core and apps chore(hordeyml): Add keywords for packagist style: php-cs-fixer fix: #23 PHP 8.4 deprecation of implicit nullable type Resolve user for device handling in ActiveSync Merge pull request #21 from horde/feat/issue-core-67-modern-serialization chore(hordeyml): Update autoloader rules test: Modernize test suite (2 remaining test failures) fix: serialization version upgrade test: cover serialization issues fix: Same version bug mentioned by @amulet1, probably fixed in his commits I cannot read. fix: Version bug mentioned by @amulet1 in review fix(activesync): Missing property declarations to Exporter/Base feat(activesync): add modern __serialize()/__unserialize() methods to Folder classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.