fix: Do not escape wildcard in objectclass from admin config#3
Merged
ralflang merged 1 commit intoJun 2, 2025
Merged
Conversation
The default objectclass filter in Horde's LDAP config is ['*'], but this value was being escaped to '\2A', resulting in invalid filters like (objectclass=\2A) instead of (objectclass=*). This patch disables escaping for values coming from trusted configuration. Values from user input are still escaped to prevent LDAP injection.
7abb184 to
d7a59b5
Compare
Member
|
There are some rebase conflicts and the CI is red. I will fixup this. |
Member
|
Released as https://packagist.org/packages/horde/ldap#v3.0.0alpha9 - thank you very much. Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default objectclass filter in Horde's LDAP config is ['*'], but this value was being escaped to '\2A', resulting in invalid filters like (objectclass=\2A) instead of (objectclass=*). This patch disables escaping for values coming from trusted configuration.
Values from user input are still escaped to prevent LDAP injection.