Skip to content

Conversation

@laurynasgadl
Copy link
Member

@laurynasgadl laurynasgadl commented Jan 22, 2026

Summary by CodeRabbit

  • New Features
    • Archive and unarchive operations now support configurable directory permissions, allowing users to specify the file mode for directories created during archive extraction and creation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes extend the public function signatures for Unarchive and Archive to accept a new dirMode parameter of type fs.FileMode, allowing directory permissions to be configurable. Both functions are updated to use this parameter during directory creation instead of hardcoded constants. Call sites in tests and HTTP handlers are updated to pass the new parameter.

Changes

Cohort / File(s) Summary
Archive API Updates
hostinger/archive.go
Extended Unarchive and Archive function signatures to accept dirMode fs.FileMode parameter; updated directory creation calls to use the new parameter instead of fs.ModeDir constant
Test Updates
hostinger/archive_test.go
Updated Archive and Unarchive function calls to pass 0755 as the new dirMode argument
HTTP Handler Updates
http/resource.go
Propagated DirMode parameter to Archive and Unarchive function calls

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@laurynasgadl laurynasgadl merged commit 3c5cb22 into master Jan 22, 2026
3 of 4 checks passed
@laurynasgadl laurynasgadl deleted the fix/archive-dir-permissions branch January 22, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant