Skip to content

Conversation

@fiatjaf
Copy link
Contributor

@fiatjaf fiatjaf commented Feb 19, 2025

No description provided.

@ZenenTreadwell
Copy link

https://github.com/hoytech/strfry/actions/runs/13416417248/workflow?pr=137#L37

Can you change this to v4 so the build test passes?

@fiatjaf
Copy link
Contributor Author

fiatjaf commented Mar 13, 2025

Didn't work.

@ZenenTreadwell
Copy link

ZenenTreadwell commented Mar 13, 2025

https://github.com/hoytech/strfry/actions/runs/13835507990/workflow?pr=137#L19

Try adding build-essential to the packages that get installed here

Edit: I think it needs to be installed here, actually - https://github.com/hoytech/strfry/actions/runs/13835507990/workflow?pr=137#L30

@vitorpamplona
Copy link

@fiatjaf can we extend this PR to have and check against a set of authed pubkeys as per nostr-protocol/nips#1881 ?

@zk-bits
Copy link

zk-bits commented Sep 29, 2025

Hi @fiatjaf and others following this PR,

I've created a new PR that includes your NIP-42 implementation with fixes for the CI failures that were blocking this from merging.

What was fixed:

  • Updated GitHub Actions to v4
  • Added build-essential to the build dependencies
  • Updated Docker build actions to v3

All CI checks are now passing (ubuntu build + multi-platform Docker builds for amd64/arm64).

New PR: #156

I wanted to let you know rather than leave this work abandoned. If you'd prefer to update this PR yourself with the CI fixes, I'm happy to close mine.

Thanks for the original implementation work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants