fix(config-flow): make manual-add pairing menu reachable (v1.1.1)#3
Merged
Conversation
…dd is reachable
The v1.1.0 manual-add menu was wired to async_step_blind on the false
assumption that HA initiates a subentry flow at async_step_{subentry_type}.
HA actually initiates user-triggered subentry flows at async_step_user, so
async_step_blind was never called and the old auto-pair form (async_step_user)
was always shown — the new menu was unreachable on every HA version.
- async_step_blind -> async_step_user: now serves the menu
(menu_options ["pair", "manual_add"]); removed redundant async_step_menu.
- old auto-pair async_step_user -> async_step_pair (form step_id "pair").
- strings.json + translations/{en,de,es,fr}.json: step.user -> step.pair,
menu_options.user -> menu_options.pair; add localized menu step to de/es/fr
(previously missing).
- tests: entry-step menu test now calls async_step_user expecting "pair";
add test_pair_step_shows_form.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QwPMgtiypLgJ5nkR3mUGfL
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QwPMgtiypLgJ5nkR3mUGfL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.1.0 "Add manually (already paired)" menu was never reachable. The subentry pairing flow was wired to
async_step_blind, on the assumption that Home Assistant initiates a subentry flow atasync_step_{subentry_type}. HA actually initiates user-triggered subentry flows atasync_step_user(HA docs), soasync_step_blindwas dead code and users always landed on the old auto-pair form — on every HA version.Changes
async_step_blind→async_step_user: now serves the menu (menu_options: ["pair", "manual_add"]); removed the redundant subentryasync_step_menu.async_step_user→async_step_pair(formstep_iduser→pair).strings.json+translations/{en,de,es,fr}.json:step.user→step.pair,menu_options.user→menu_options.pair; added the localizedmenustep to de/es/fr (it was missing entirely).async_step_userexpecting thepairoption; addedtest_pair_step_shows_form.Verification
ruff check✅ ·mypy✅ · fullpytest164 passed (WSL)Release
Patch bump
manifest.json→ 1.1.1. After merge, tagv1.1.1to trigger the HACS release workflow.🤖 Generated with Claude Code