Fix bug in week2-NER.ipynb that misses last tweet when reading data.#42
Open
ca-scribner wants to merge 1 commit intohse-aml:masterfrom
Open
Fix bug in week2-NER.ipynb that misses last tweet when reading data.#42ca-scribner wants to merge 1 commit intohse-aml:masterfrom
ca-scribner wants to merge 1 commit intohse-aml:masterfrom
Conversation
…Add implicit file closing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code misses last tweet unless file ends with two empty lines (a single empty line is interpreted by the for loop as the end of the file and thus is not passed to the code at all, which means we never reach the "if not line" inside the loop for the last tweet). Use a for/else to catch the last tweet.
With block added to implicitly close file. Not necessary to fix above bug