Skip to content

[Snyk] Security upgrade webpack-dev-server from 3.7.1 to 4.7.3#181

Open
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-eb2f0041a383eaf25c65958313bde663
Open

[Snyk] Security upgrade webpack-dev-server from 3.7.1 to 4.7.3#181
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-eb2f0041a383eaf25c65958313bde663

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Nov 28, 2025

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • www/build_common/package.json
  • www/build_common/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
critical severity Interpretation Conflict
SNYK-JS-NODEFORGE-14114940
  180  
high severity Uncontrolled Recursion
SNYK-JS-NODEFORGE-14125745
  125  
medium severity Integer Overflow or Wraparound
SNYK-JS-NODEFORGE-14125097
  44  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.


Important

Upgrade webpack-dev-server to 4.7.3 to fix security vulnerabilities in node-forge.

  • Dependency Upgrade:
    • Upgrade webpack-dev-server from 3.7.1 to 4.7.3 in package.json and yarn.lock.
  • Security:
    • Fixes vulnerabilities: Interpretation Conflict, Uncontrolled Recursion, Integer Overflow or Wraparound related to node-forge.
  • Yarn Zero-Installs:
    • Users need to run yarn to update .yarn/cache/ if using zero-installs.

This description was created by Ellipsis for 74e3679. You can customize this summary. It will automatically update as commits are pushed.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Nov 28, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 28, 2025

⚠️ No Changeset found

Latest commit: 74e3679

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
buildbot Error Error Nov 28, 2025 6:04am
csb-b6x6kw Ready Ready Preview Comment Nov 28, 2025 6:04am

Copy link
Copy Markdown

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 74e3679 in 1 minute and 9 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. www/build_common/package.json:37
  • Draft comment:
    Upgraded webpack-dev-server to ^4.7.3 is a major version upgrade. Please verify that your webpack-dev-server configuration is updated in line with v4's breaking changes (e.g. config options like 'contentBase' may need to be replaced by 'static').
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The rules explicitly state "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." This comment is directly about a dependency version upgrade. Even though it's a major version change with potential breaking changes, the rules are clear that dependency changes should not be commented on. Additionally, the comment asks the author to "verify" something, which violates the rule about not asking the PR author to confirm, double-check, or ensure things. While major version upgrades can introduce breaking changes that could cause real issues, the rules explicitly exclude dependency-related comments. Perhaps the rule is too broad and this type of comment about breaking changes in major versions could be valuable? Even if this could be a valuable comment in some contexts, the rules are explicit and clear: "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." This is unambiguously a dependency change comment. Additionally, it asks the author to "verify" which is also explicitly prohibited. This comment should be deleted because it violates two rules: it comments on a dependency change, and it asks the PR author to verify/confirm something. Both are explicitly prohibited by the review guidelines.

Workflow ID: wflow_lzYyk8sQohIsqkfk

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants