Conversation
…duce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to eb6ca05 in 40 seconds. Click for details.
- Reviewed
25lines of code in1files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. www/build_common/package.json:15
- Draft comment:
html-webpack-plugin upgraded to ^4.0.0. This major version bump may require changes in your webpack config. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency change, specifically a major version upgrade of a plugin. It suggests that the upgrade may require changes in the webpack configuration, but it doesn't provide a specific suggestion or ask for confirmation of an intentional change. According to the rules, comments on dependency changes should be ignored unless they provide specific actionable feedback.
2. www/build_common/package.json:35
- Draft comment:
Webpack upgraded to ^5.0.0. Ensure all webpack configs and related plugins/loaders are compatible with webpack 5. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically the upgrade of Webpack to version 5. The comment advises ensuring compatibility with the new version, which falls under the rule of not asking the PR author to ensure compatibility or test changes. Therefore, this comment should be removed.
3. www/build_common/package.json:37
- Draft comment:
webpack-dev-server upgraded to ^4.0.0. Verify that your devServer configuration matches the breaking changes in v4. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically the upgrade ofwebpack-dev-serverto version 4. The comment asks the PR author to verify their configuration against breaking changes, which is not allowed according to the rules. The comment does not provide a specific suggestion or point out a specific issue with the code.
Workflow ID: wflow_3W0f1NW8XcYFoRY4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
www/build_common/package.jsonwww/build_common/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-LODASH-15053838
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution
Important
Update
html-webpack-plugin,webpack, andwebpack-dev-serverinpackage.jsonto fix vulnerabilities and note for zero-installs users.html-webpack-pluginfrom^3.2.0to^4.0.0inpackage.json.webpackfrom^4.30.0to^5.0.0inpackage.json.webpack-dev-serverfrom^3.3.1to^4.0.0inpackage.json.SNYK-JS-TAR-15038581,SNYK-JS-ELLIPTIC-14908844,SNYK-JS-LODASH-15053838.yarnto update the cache directory.This description was created by
for eb6ca05. You can customize this summary. It will automatically update as commits are pushed.