- mod_gss.c must provide its own definition of get_v4inaddr()#4
Open
Sashan wants to merge 1 commit into
Open
Conversation
Perhaps we should talk to T.J. to create a public version of get_v4inaddr() for gssmod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps we should talk to T.J. to create a public version
of get_v4inaddr() for gssmod
This change fixes channel binding for IPv4 addresses mapped to IPv6 addresses.
mod_gss relies on
get_v4inaddr()which is implemented inproftpd/src/netaddr.c.The function is defined as
static, hence it is invisible to other modules.If we would have been linking mod_gss to proftpd statically, then we could discover the
bug at build time. Unfortunately we deliver mod_gss as
.soplugin, hence the problem is discovered by runtime linker, which just kills session process as soon as mod_gss calls toget_v4inaddr().