Skip to content

Add flag to write output to JSON#17

Open
mattnappo wants to merge 1 commit into
huggingface:mainfrom
mattnappo:output-file
Open

Add flag to write output to JSON#17
mattnappo wants to merge 1 commit into
huggingface:mainfrom
mattnappo:output-file

Conversation

@mattnappo

Copy link
Copy Markdown

This uses serde_json to write the output of a run as a json file.

@Hugoch Hugoch self-requested a review January 14, 2026 15:29
@Hugoch

Hugoch commented Jan 15, 2026

Copy link
Copy Markdown
Member

Hey @mattnappo ! Thanks for your contribution, makes sense to have some JSON output for result parsing.
In your approach you are cloning the results and then building the summary, I think we can avoid cloning and rather build a global summary that can then be output via different writes (like ConsoleWrite, JsonWriter...).
It makes it more reusable and avoids cloning/computing twice the results.

@Hugoch Hugoch mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants