Conversation
- RMSNorm, RoPE 3D, GEGLU, AdaLN kernel patterns - Benchmark scripts (micro + e2e for LTX-Video) - HuggingFace Kernels integration example - Reference docs: optimization guides, templates, troubleshooting
|
Cc: @burtenshaw @danieldk |
|
Really cool PR! Could you please share a trace with a coding harness like claude code, codex, or opencode. |
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks for this 🔥
I will let @burtenshaw do the final approval. Some comments:
- https://huggingface.co/docs/kernels/main/en/cli-skills should be likely modified to mention that ROCm kernels are also supported.
- Could we also see some numbers with and without these kernels, and preferably some videos?
| @@ -0,0 +1,252 @@ | |||
| # Diffusers Pipeline Integration Guide (ROCm) | |||
|
|
|||
| Integrating custom Triton kernels into HuggingFace diffusers pipelines on AMD GPUs. | |||
There was a problem hiding this comment.
Should we also enlist any dependencies?
There was a problem hiding this comment.
No problem, I will add some dependencies in 24 hours!
|
This is really good 🔥 Thanks @01xjw |
Hi @burtenshaw, the show results are in the blog PR, could you help review it also? Thanks ~ |
OK — I’ll add the ROCm kernel skills to this repo following the CLI skills docs. |
5 participants
Add ROCm Triton kernels skill for MI355X/R9700