Open
Conversation
gabrielnau
approved these changes
Sep 26, 2018
sbellity
requested changes
Sep 26, 2018
| this.metrics = metrics; | ||
| metrics.init({ | ||
| host: process.env.HOST, | ||
| host: process.env.DATADOG_HOST || process.env.HOST, |
Contributor
There was a problem hiding this comment.
Actually I would fallback to a hardcoded value here. It will be easier to manage and make sure we don't send a different host by default for each new connector if the DATADOG_HOST variable is not set.
Contributor
Author
There was a problem hiding this comment.
Hm, not sure about putting our infra specific URL in this library. What we can do differently to achieve what's important to you is to exit the process early with a descriptive error when DATADOG_HOST env var is missing and we have DATADOG_API_KEY present.
@sbellity @gabrielnau?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.