feat: update comm ops ods and add testcases

[FangRui0]

No description provided.

[gemini-code-assist]

Code Review

This pull request refactors the PTO communication dialect by renaming collective operations, implementing a more readable custom assembly format, and updating the EmitC lowering to utilize a new ParallelGroup abstraction. Feedback on the changes suggests improving the robustness of the MLIR Python bindings in the new test samples by explicitly handling optional operands with None and using keyword arguments for operation attributes to prevent potential positional argument mismatches.

[gemini-code-assist]

In MLIR Python bindings, operations with AttrSizedOperandSegments and Optional operands typically require all positional arguments to be provided in order. Since TBroadcastOp has an optional pong operand before the variadic group, passing group as the third positional argument might lead to a type mismatch or incorrect IR generation. It is safer to pass None for the optional pong and use keyword arguments for attributes like root.

Suggested change

	pto.TBroadcastOp(src, ping, group, 1)
	pto.TBroadcastOp(src, ping, None, group, root=1)

[gemini-code-assist]

Similar to the broadcast operation, CommTGatherOp has an optional pong operand. The current positional call skips it, which may cause issues with standard MLIR Python bindings. Using explicit None for optional operands and keyword arguments for attributes is recommended.

Suggested change

	pto.CommTGatherOp(dst, ping, group, 1)
	pto.CommTGatherOp(dst, ping, None, group, root=1)

[gemini-code-assist]

The positional arguments here skip the optional pong operand. To ensure robustness across different MLIR binding versions, please provide None for the optional operand and use a keyword argument for the root attribute.

Suggested change

	pto.CommTScatterOp(src, ping, group, 1)
	pto.CommTScatterOp(src, ping, None, group, root=1)

[gemini-code-assist]

The TReduceOp has an optional recvPong operand. The current call passes group in its place positionally. Additionally, attributes like reduceOp and root should ideally be passed as keyword arguments to avoid ambiguity and potential binding errors.

Suggested change

	pto.TReduceOp(
	dst,
	acc,
	recv,
	group,
	pto.ReduceOpAttr.get(pto.ReduceOp.Sum, ctx),
	1,
	)
	pto.TReduceOp(
	dst,
	acc,
	recv,
	None,
	group,
	reduceOp=pto.ReduceOpAttr.get(pto.ReduceOp.Sum, ctx),
	root=1,
	)

[reedhecre]

Codex Review

该评论由 review 机器人自动更新。

• PR: feat: update comm ops ods and add testcases #648 feat: update comm ops ods and add testcases
• Author: FangRui0
• Base/Head: main / comm_op
• Head SHA: 9ada56e8eebb
• Trigger: PR 有新提交
• Generated At: 2026-05-09T12:14:48Z
• Previous Head SHA: 1223b1077300
• Status: completed

Summary

PR #648 introduces backward-incompatible communication-op IR changes: it renames collective mnemonics and removes parsing support for the previously accepted p2p/signal syntax.

Findings

1. P2 Renaming `comm_tgather`/`comm_tscatter` breaks existing textual IR compatibility include/PTO/IR/PTOOps.td:1778

This changes the public op names from pto.comm.comm_tgather / pto.comm.comm_tscatter to pto.comm.tgather / pto.comm.tscatter, but there is no parser alias or compatibility shim for the old spellings. origin/main still documents and tests the old mnemonics, so any existing .pto IR using them will stop assembling after this lands. The v0 opcode table was updated to emit only the new names as well, so old textual IR and bytecode/text round-trips no longer preserve the previous contract.

2. P2 New comm-op assembly formats drop support for the previously accepted PTO IR syntax include/PTO/IR/PTOOps.td:1671

The assembly form for pto.comm.tput, tget, tnotify, twait, and ttest now only accepts the new parenthesized syntax (buf(...), typed signal operands, etc.). There is no custom parser support for the old surface syntax that origin/main documents (for example pto.comm.tput %dst, %src, %ping ... and pto.comm.tnotify %sig, %v ...). Existing .pto files written against the current syntax will fail to parse after upgrade, which is a user-visible compatibility regression.