Remove pkg_resources import (deprecated module)#1072
Merged
hydrosquall merged 3 commits intohydrosquall:masterfrom Jan 8, 2025
furechan:fix_pkg_resources
Merged
Remove pkg_resources import (deprecated module)#1072hydrosquall merged 3 commits intohydrosquall:masterfrom furechan:fix_pkg_resources
hydrosquall merged 3 commits intohydrosquall:masterfrom
furechan:fix_pkg_resources
Conversation
hydrosquall
approved these changes
Jan 8, 2025
Owner
hydrosquall
left a comment
There was a problem hiding this comment.
Thank you! Looks like this will fix #1071
| MissingRequiredArgumentError, | ||
| ) | ||
|
|
||
| from tiingo.__version__ import __version__ as VERSION |
Owner
There was a problem hiding this comment.
I wonder why we couldn't have used this syntax to begin with 😅 . Assuming all unit tests pass, this looks good to me. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
pkg_resourcesis deprecated and causing import warnings in recent python versionspkg_resourceswas used only to fetch the package version asVERSION__version__submodulepkg_resourcesorimportlib.metadataChecklist
HISTORY.rstwith an entry summarizing your change