feat: offline mode and static GitHub Pages build#158
Closed
madjin wants to merge 21 commits intohyperfy-xyz:devfrom
Closed
feat: offline mode and static GitHub Pages build#158madjin wants to merge 21 commits intohyperfy-xyz:devfrom
madjin wants to merge 21 commits intohyperfy-xyz:devfrom
Conversation
Introduce a runtime connection policy resolver so networking mode (direct-connect vs offline) is decided at boot without touching any shared system callsites. OfflineNetwork is a null-object that satisfies the ~70 world.network access sites, and PUBLIC_WS_URL is now optional on the server side. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a subtle status dot (bottom-right) that expands into a panel showing connection mode, network ID, server URL input, and connect/offline/reset actions. Register /connect, /offline, and /reconnect chat slash commands via a new ClientConnection system. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add `npm run static:build` for self-contained GitHub Pages deployment - Copy default world assets (avatar, emotes, animations) into static output - GitHub Actions workflow for auto-deploying to Pages - Offline bootstrap now spawns a local PlayerLocal with avatar, camera, and full controls instead of an empty black screen - Set assetsUrl so asset:// protocol resolves in offline mode - Load base-environment.glb and HDR sky in offline mode - ConnectionBadge: contextual buttons (hide "Go Offline" when already offline, highlight primary action green) - ConnectionBadge: auto-expand on connection failure so user can retry - CoreUI: hide loading overlay on pre-ready disconnect instead of staying stuck forever - CoreUI: gate player-dependent UI on `ready && player` to prevent null crashes in offline mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Parse connect URLs with URL constructor and rebuild as origin+pathname only, stripping any query params or fragments. A crafted URL like ws://evil.com/ws?steal= would cause ClientNetwork.init() to append ?authToken=<token> to the attacker's query string. Applied consistently in all three input paths: resolveConnectionMode, ConnectionBadge UI, and /connect chat command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replaces the bottom-right floating ConnectionBadge dot with a wifi button in the sidebar icon column. Panel pops out to the right like other panes, shows server URL input, online/offline status with ping, and a connect/disconnect toggle. Emits ping event from ClientNetwork so the panel can display live latency. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…atic build Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ng files - Merge /connect, /offline, /reconnect commands into ClientNetwork.init() - Inline resolveConnectionMode logic directly in client/index.js - Wire navigateToServer helper into Sidebar.handleConnect - Delete ClientConnection.js and resolveConnectionMode.js Net result: 3 new files → 1 (OfflineNetwork.js remains). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Eliminate the null-object class by handling the no-wsUrl case directly in ClientNetwork.init(). Four small guards replace the entire separate file, and the NetworkSystem override param is removed from createClientWorld. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Triggers on pushes to main (live preview) and feat/connection-policy-layer (in-flight preview). Uses actions/deploy-pages — configure Pages source via Settings → Pages → Source: GitHub Actions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Switches from actions/deploy-pages artifact approach to peaceiris/actions-gh-pages, which commits only the built files to the gh-pages branch. Trigger: push to dev. Configure GitHub Pages: Settings → Pages → Deploy from branch → gh-pages → / (root) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat: connection policy layer for offline/solo mode
* ci: bump all GitHub Actions dependencies to latest major versions
actions/checkout v4 → v6
actions/setup-node v4 → v6
docker/login-action v3 → v4
docker/metadata-action v5 → v6
docker/setup-qemu-action v3 → v4
docker/setup-buildx-action v3 → v4
docker/build-push-action v6 → v7
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: resolve static assets correctly on GitHub Pages sub-paths
Compute an absolute base URL (new URL('./', location.href)) for offline
mode so bare filenames and /absolute paths don't break when the site is
served at a sub-path like /hyperfy/. Passes assetsUrl into world.init so
updateSky fires with the correct HDR URL. Removes redundant explicit HDR
load since ClientEnvironment handles it via baseEnvironment.hdr.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- index.css: url(/rubik.woff2) → url(rubik.woff2) — absolute path broke on sub-paths like /hyperfy/ - world-client.js: restore explicit scene.background = hdr for offline mode; ClientEnvironment.updateSky only sets scene.environment (reflections), not the visible sky background Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…st-xml-parser) - npm audit fix: updated fastify, flatted, minimatch, ajv, brace-expansion - Added fast-xml-parser override to ^5.5.6 to fix AWS SDK transitive vuln - Remaining: esbuild dev-server advisory (requires breaking upgrade, skipped) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Not intended for upstream; skill lives outside the project. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…line) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
madjin
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?mode=offline) for fully client-side operationnpm run static:build)?connect=ws://...) for localhostPUBLIC_WS_URLoptional on server (HTTP-only mode with warning)Non-breaking
Existing deployments with current
.envsettings behave identically. All new features are additive.Depends on #159 (maintenance/docs changes split out for easier review).
Test plan
npm run dev— server starts, world loads, multiplayer works?mode=offline— client boots without WebSocketnpm run static:build— produces working offline client inbuild/static/PUBLIC_WS_URL— server starts HTTP-only with warning?connect=ws://localhost:3000/ws— direct connect works on localhost🤖 Generated with Claude Code