Use JsonDocument instead of TextDocument#17
Merged
Merged
Conversation
srivastava-diya
approved these changes
Jun 14, 2026
srivastava-diya
left a comment
Collaborator
There was a problem hiding this comment.
The JsonDocument model is very helpful having JSON specific methods like findNodeAtPointer and getParseErrors directly on the document will make hover, schema store integration, and completions much cleaner. Looking forward to building on top of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured out how to define a
JsonDocumentthat extendsTextDocumentso we can add JSON-specific capabilities. The primary driver for this was that it allows theJsonDocumentto handle parsing the document so each feature doesn't have to parse the document individually.I expect we'll add more things here as we go including determining the schema that applies to the document.