CI hygiene: drop redundant trufflehog job (+ Deno @cadre/router dup pending)#122
Merged
Conversation
The hand-rolled `trufflehog` job was both unpinned (`@main`, failing the
Workflow security linter) and passed `--fail` on top of the action's own
`--fail` ("flag 'fail' cannot be repeated"). The reusable `scan` job
(hyperpolymath/standards secret-scanner-reusable, SHA-pinned) already runs
trufflehog — the passing `scan / trufflehog` check — so the local job was
pure duplication. Remove it: fixes both red checks and de-duplicates
secret scanning.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019i2e5ABGBKQmMdqk8puFWx
The root deno.json workspace listed ./rescript-ecosystem/cadre-router,
.../cadre-router/tea-router, .../cadre-router/tea-router-pkg and
.../cadre-tea-router as copies of the canonical top-level ./cadre-router /
./cadre-tea-router, so two workspace members declared @cadre/router and
Deno rejected the workspace ("cannot have the same name"). The top-level
dirs are canonical (registered cadre satellites, go-forward AffineScript
policy); the rescript-ecosystem copies are legacy. Remove the legacy
entries from the workspace (files retained on disk, just not workspace
members), clearing the duplicate-package error.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019i2e5ABGBKQmMdqk8puFWx
create-poly/deno.json declared @hyperpolymath/rescript-poly-core — the name already owned by packages/core/poly-core — so Deno rejected the workspace once the cadre duplicates were removed (it only reports one collision at a time). The file was clearly copied from poly-core. Rename the package to @hyperpolymath/rescript-create-poly. This was the last duplicate package name in the workspace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019i2e5ABGBKQmMdqk8puFWx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-existing CI failures on
main, split out of the now-merged k9-ecosystem PR (#120) so that PR stayed focused. None were introduced by #120. Both now fixed.Fixed here
Secret Scanner / Workflow security linter + trufflehog —
secret-scanner.ymlhad a hand-rolledtrufflehogjob that was both unpinned (trufflehog@main) and passed--failon top of the action's own--fail(flag 'fail' cannot be repeated). The reusablescanjob (SHA-pinnedhyperpolymath/standardssecret-scanner) already runs trufflehog — the passingscan / trufflehogcheck — so the local job was pure duplication. Removed it.Language / package anti-pattern — the root
deno.jsonworkspace listed./rescript-ecosystem/cadre-router,.../cadre-router/tea-router,.../cadre-router/tea-router-pkg, and.../cadre-tea-routeras copies of the canonical top-level./cadre-router/./cadre-tea-router, so two members declared@cadre/router. Unlisted the legacyrescript-ecosystem/cadre-*entries from the workspace (files retained on disk; top-level dirs are canonical).🤖 Generated with Claude Code
https://claude.ai/code/session_019i2e5ABGBKQmMdqk8puFWx