ci: de-gate required-check workflows to run on every PR base#308
Merged
Conversation
codeql.yml and hypatia-scan.yml restricted their pull_request trigger to branches:[main,master]. The jobs they run are required status checks, so on a PR whose base is not main/master the check is never created and the PR is blocked forever at "Expected — Waiting for status to be reported". Removing the branch filter makes the required checks report on every PR base; push/schedule triggers are unchanged. Mirrors the affinescript fix in #645. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UXXpaoiATzxcn3kW3eTM26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
pull_request: branches:[main, master]filter fromcodeql.ymlandhypatia-scan.ymlso their required jobs —analyze (actions, none)/analyze (rust, none)andhypatia / Hypatia Neurosymbolic Analysis— report on PRs against every base.push:andschedule:triggers are unchanged.Why
A required status check whose workflow is branch-filtered is never created on a non-matching base, so the PR sits permanently at "Expected — Waiting for status to be reported" — a silent merge block indistinguishable from a hang.
Observed live on this repo: PR #307 had no
hypatia / Hypatia Neurosymbolic Analysisand noHypatiacheck at all. This mirrors hyperpolymath/affinescript#645, which diagnosed and fixed the same class. No governance change is needed here — this repo still emitsgovernance / Validate Hypatia baselinenatively via thestandardsreusable.🤖 Generated with Claude Code
https://claude.ai/code/session_01UXXpaoiATzxcn3kW3eTM26
Generated by Claude Code