This repository was archived by the owner on Apr 19, 2023. It is now read-only.
Fixed tokenStorageGet and authenticateExistingSession#11
Open
Fixed tokenStorageGet and authenticateExistingSession#11
Conversation
to account for when the token file does not exist
alicerunsonfedora
suggested changes
May 1, 2022
| fun authenticateExistingSession(): Boolean { | ||
| val (token, date, integrity, _) = tokenStorageGet().split(";") | ||
| val storedToken = tokenStorageGet() | ||
| if (storedToken == "") return false |
Member
There was a problem hiding this comment.
I think we should have it written as the following to be more clear as to what we're checking:
if (storedToken.isEmpty())
return false| val fileContent = Files.readAllLines(Path.of(getAbsolutePath())) | ||
| return fileContent[2] | ||
| } catch (e: IOException) { | ||
| return "" |
Member
There was a problem hiding this comment.
Let's be sure to add documentation on this so we know it returns an empty string if the token couldn't be parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to account for when the token file does not exist