-
Notifications
You must be signed in to change notification settings - Fork 7
Changes to add Created Date, Last Modified Date, last Modified by Audit details #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DibyojyotiS
merged 12 commits into
main
from
AAP-9761-config-svc-changes-to-add-created-date-last-modified-date-last-modified-by-audit-details
Dec 17, 2025
Merged
Changes to add Created Date, Last Modified Date, last Modified by Audit details #323
DibyojyotiS
merged 12 commits into
main
from
AAP-9761-config-svc-changes-to-add-created-date-last-modified-date-last-modified-by-audit-details
Dec 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied by Audit details
config-object-store/src/main/java/org/hypertrace/config/objectstore/ConfigObject.java
Outdated
Show resolved
Hide resolved
config-object-store/src/main/java/org/hypertrace/config/objectstore/ConfigObject.java
Outdated
Show resolved
Hide resolved
config-object-store/src/main/java/org/hypertrace/config/objectstore/ConfigObject.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigDocument.java
Outdated
Show resolved
Hide resolved
config-service/src/main/resources/configs/common/application.conf
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigDocument.java
Outdated
Show resolved
Hide resolved
config-object-store/src/main/java/org/hypertrace/config/objectstore/ConfigObject.java
Outdated
Show resolved
Hide resolved
config-object-store/src/main/java/org/hypertrace/config/objectstore/ConfigObject.java
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
…ail) changes: default substititions only at read
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
============================================
- Coverage 75.73% 75.60% -0.13%
- Complexity 556 598 +42
============================================
Files 63 65 +2
Lines 2839 3033 +194
Branches 134 147 +13
============================================
+ Hits 2150 2293 +143
- Misses 607 647 +40
- Partials 82 93 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
refactor: split buildConfigDocument into create and update methods
Gg-harness
reviewed
Dec 11, 2025
...e-api/src/testFixtures/java/org/hypertrace/config/service/test/MockGenericConfigService.java
Show resolved
Hide resolved
Gg-harness
approved these changes
Dec 11, 2025
…ate-last-modified-date-last-modified-by-audit-details
config-object-store/src/main/java/org/hypertrace/config/objectstore/ConfigObject.java
Show resolved
Hide resolved
singhalprerana
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds audit fields to the config-service to track config creation and modification by users. Specifically, this feature adds:
created_by: Email of the user who originally created the configlast_modified_by: Email of the user who last modified the configThese fields are now exposed in all config service responses (UpsertConfigResponse, GetConfigResponse, ContextSpecificConfig, and UpsertAllConfigsResponse.UpsertedConfig) to provide better auditability and tracking of config changes.
Key Implementation Details:
created_byfield is set when a config is initially created and remains immutable during updateslast_modified_byfield is updated on every modificationConfigDocumentmodel extended withcreatedByUserEmailfieldConfigObjectinterface extended withgetCreatedBy()andgetLastModifiedBy()methodsDocumentConfigStorelogic updated to preserve creator email on updatesTesting
testCreatorEmailIsSetOnCreate(): Verifies creator email is set on config creationtestCreatorEmailIsPreservedOnUpdate(): Ensures creator email remains unchanged during updatesIdentifiedObjectStoreTest.javaIdentifiedObjectStoreWithFilterTest.javaDefaultObjectStoreTest.javaContextuallyIdentifiedObjectStoreTest.javaDocumentConfigStoreTest.javaConfigDocumentTest.javaAll tests pass successfully.
Checklist:
Documentation
Proto file comments have been added to document the new audit fields.