feat: add callback support in send method of event producer #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The send method in our KafkaEventProducer library calls the send method of Apache's KafkaProducer which returns a Future but our library ignores it. As the documentation says, "The send is asynchronous and this method will return immediately once the record has been stored in the buffer of records waiting to be sent." Calling send() does NOT mean the record is already written to Kafka. If the client wants to check/ensure that the record was successfully written to Kafka, the client should check the Future returned by Apache KakaProducer's send method or provide a callback to the send method. But our library doesn't provide any of these capabilities. So, there is no way for the client of our library to know if there were any errors while writing to Kafka.
To address this shortcoming, I've added send method which accepts a callback.