fix: harden ACP image path handling#477
Merged
Merged
Conversation
- Complete path-only Codex image outputs when saved_path points to an image file - Avoid treating non-image saved_path values as generated images - Filter empty image paths before status normalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saved_pathpoints to an image file.saved_pathvalues as generated images.Verification
cargo fmt --checkcargo test -p aionui-ai-agent codex_ -- --test-threads=1cargo test -p aionui-conversation run_acp_image_tool_call_update_persists_finish_without_base64cargo clippy -p aionui-ai-agent -p aionui-conversation --all-targets -- -D warnings