This repository was archived by the owner on Apr 21, 2026. It is now read-only.
Fix crash with Valkyrien Skies 2.4.11 [1.20.1]#1818
Open
Acuadragon100 wants to merge 4 commits into
Open
Conversation
…s in dev. We don't really need to bundle it anymore either.
…g MixinExtras to fix crash with Valkyrien Skies 2.4.11.
…tras version 0.5.0.
Member
|
Thanks for the PR, but I am no longer maintaining this repo. You can maintain it in your own fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of Valkyrien Skies adds a mixin into
Frustum::offsetToFullyIncludeCameraCube.This presents a problem since there is an
@Overwritemixin on that method in Immersive Portals 5.2.0. That's why I made this pull request to rewrite it in a more compatible way.I also noticed that Immersive Portals was still bundling an old version of MixinExtras for some reason, so I got rid of that and set the dev environment to use the a more recent version of loom and Fabric Loader. I also set the minimum reqiured version of Fabric Loader in fabric.mod.json to 0.17 since that was the first version of Fabric Loader to bundle MixinExtras version 0.5.0.