Remove legacy localisation script references and actions#2
Remove legacy localisation script references and actions#2iangmaia wants to merge 4 commits intocleanup/remove-skip-glotpress-issue-372from
Conversation
We now have newer, better actions to achieve the same results: - `ios_generate_strings_file_from_code` - `ios_extract_keys_from_strings_files` - `ios_download_strings_files_from_glotpress` - `ios_merge_strings_files`
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Looking good.
I checked this locally and run the test, which passed.
I didn't go down the route of opening a PR for this on the main repo to trigger CI because I see this is incremental on top of another one and I'd like to know how you plan to merge them.
| ### Breaking Changes | ||
|
|
||
| - Remove the `skip_glotpress` parameter from the `ios_bump_version_release` action [#443] | ||
| - Remove the actions `ios_localize_project` and `ios_update_metadata` |
There was a problem hiding this comment.
There's no PR number here, but that's to be expected give this PR is on your fork
| # | ||
| def self.commit_version_bump(include_deliverfile: true) | ||
| files_list = [File.join(ENV['PROJECT_ROOT_FOLDER'], 'config', '.')] | ||
| files_list = [File.join(get_from_env!(key: 'PROJECT_ROOT_FOLDER'), 'config', '.')] |
There was a problem hiding this comment.
Nice that you updated this while touching the file, and that it was done in a dedicated commit 👍
Thanks @mokagio 👍 My plan is: once wordpress-mobile#443 gets merged, I'll target this PR to the main repo's trunk, but pleas let me know if you have other ideas or if another process is preferred. |
|
Just merged wordpress-mobile#443 🙂 |
|
Ah, just noticed that you can't switch forks when editing the Pull Request (which makes sense, the PRs are for a repo), only branches... Anyway, I'll just create another one for this branch to the main repo now that 443 has been merged 🙂 |
3 participants
EDIT: this PR was re-created in the main repo: wordpress-mobile#447
What does it do?
This is a clean up removing the remainder references to the legacy localisation tooling, following up the #433 PR.
It contains:
ios_localize_projectandios_update_metadata.localize_project,update_metadataandstrings_filesonIos::GitHelperinclude_metadatafrom the methodIos::GitHelper.commit_version_bump(include_deliverfile:)Related PRs
Deliverfile.Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the approprioate existing###subsection of the existing## Trunksection.