Repair Interpolation#21
Merged
Merged
Conversation
br648
requested changes
May 7, 2026
br648
left a comment
br648
left a comment
There was a problem hiding this comment.
Some changes required. How are you testing this?
binh-dam-ibigroup
requested changes
May 11, 2026
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Could you clarify the exclusion of dwell time for non-timepoint stops? I also agree with @br648 that some tests should be added.
Author
|
I've added a simple test. It's not as thorough as I would've liked, but I ran into problems with how the test harness handled the shape data |
br648
reviewed
May 26, 2026
binh-dam-ibigroup
approved these changes
May 26, 2026
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Gonna approve this given the clarifications made around the assumption regarding ignoring travel times/dwell times for stops that are not timepoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing interpolation code did not work at all. This PR repairs this situation.
We replicate the functionality by creating two modes: one for re-calculating all stop times using timepoint times only (assuming that the travel time refers to time since the last timepoint), and a second for filling in only stoptimes with missing stoptimes (not using interpolation)