Skip to content

Feat/login signup public catalog#121

Merged
michael-on-code merged 9 commits into
mainfrom
feat/login-signup-public-catalog
Jun 12, 2026
Merged

Feat/login signup public catalog#121
michael-on-code merged 9 commits into
mainfrom
feat/login-signup-public-catalog

Conversation

@michael-on-code

Copy link
Copy Markdown
Contributor

Checklist

  • Tests were added/updated according to the feature/bugfix/change made
  • Version was rolled according to semver requirements
  • API endpoints openapi schema was updated if applicable

Changes

  • feat: login and signup buttons on public catalog in
  • feat: hide home, discover, recommended pages when not logged in

Preview

image

@mamigot

mamigot commented Jun 9, 2026

Copy link
Copy Markdown
Member

Claude finished @michael-on-code's task —— View job


E2E Coverage Review ✅

Reviewed PR #121 for e2e test coverage requirements.

Tasks:

  • Step 1: Dismiss stale REQUEST_CHANGES reviews (no stale reviews found)
  • Step 2: Identify what changed
  • Step 3: Run mechanical coverage check (coverage intact - no new routes)
  • Step 4: Read current coverage state
  • Step 5: Apply decision logic and post review

Analysis Results:

No new app routes: No new page.tsx files were added in this PR

  • Changed files: Dockerfile, nav-bar components, navigation-drawer, tests, and utils/helpers
  • This appears to be UI component changes for login/signup buttons without new routes

Coverage state: Current coverage is 100% (222/222 checkpoints, 31 journeys)

Test updates included: The PR includes test updates in:

  • components/__tests__/nav-bar.test.tsx
  • components/__tests__/navigation-drawer.test.tsx
  • utils/__tests__/helpers.test.ts

Review Decision: APPROVED

This is CASE E (no new page.tsx files and no coverage regression). No new app routes were introduced and all existing coverage remains intact. The PR includes appropriate component-level test updates for the navigation changes.

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

@mamigot

mamigot commented Jun 9, 2026

Copy link
Copy Markdown
Member

Claude finished @michael-on-code's task —— View job


E2E Coverage Review ✅

Reviewed PR #121 for e2e test coverage requirements.

Tasks:

  • Step 1: Dismiss stale REQUEST_CHANGES reviews (no stale reviews found)
  • Step 2: Identify what changed
  • Step 3: Run mechanical coverage check (coverage intact - no new routes)
  • Step 4: Read current coverage state
  • Step 5: Apply decision logic and post review

Analysis Results:

No new app routes: No new page.tsx files were added in this PR

  • Changed files: Dockerfile, nav-bar components, navigation-drawer, tests, and utils/helpers
  • This appears to be UI component changes for login/signup buttons without new routes

Coverage state: Current coverage is 100% (222/222 checkpoints, 31 journeys)

Test updates included: The PR includes test updates in:

  • components/__tests__/nav-bar.test.tsx
  • components/__tests__/navigation-drawer.test.tsx
  • utils/__tests__/helpers.test.ts

Review Decision: APPROVED

This is CASE E (no new page.tsx files and no coverage regression). No new app routes were introduced and all existing coverage remains intact. The PR includes appropriate component-level test updates for the navigation changes.

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

@mamigot

mamigot commented Jun 9, 2026

Copy link
Copy Markdown
Member

Claude finished @michael-on-code's task —— View job


E2E Coverage Review ✅

Reviewed PR #121 for e2e test coverage requirements.

Tasks:

  • Step 1: Dismiss stale REQUEST_CHANGES reviews (no stale reviews found)
  • Step 2: Identify what changed
  • Step 3: Run mechanical coverage check (coverage intact - no new routes)
  • Step 4: Read current coverage state
  • Step 5: Apply decision logic and post review

Analysis Results:

No new app routes: No new page.tsx files were added in this PR

  • Changed files: nav-bar components, navigation-drawer, tests, and utils/helpers
  • This appears to be UI component changes for login/signup buttons without new routes

Coverage state: Current coverage is 100% (222/222 checkpoints, 31 journeys)

Test updates included: The PR includes test updates in:

  • components/__tests__/nav-bar.test.tsx
  • components/__tests__/navigation-drawer.test.tsx
  • utils/__tests__/helpers.test.ts

Review Decision: APPROVED

This is CASE E (no new page.tsx files and no coverage regression). No new app routes were introduced and all existing coverage remains intact. The PR includes appropriate component-level test updates for the navigation changes.


@mamigot

mamigot commented Jun 10, 2026

Copy link
Copy Markdown
Member

Claude finished @michael-on-code's task —— View job


E2E Coverage Review ✅

Reviewed PR #121 for e2e test coverage requirements.

Tasks:

  • Step 1: Dismiss stale REQUEST_CHANGES reviews (no stale reviews found)
  • Step 2: Identify what changed
  • Step 3: Run mechanical coverage check (coverage intact - no new routes)
  • Step 4: Read current coverage state
  • Step 5: Apply decision logic and post review

Analysis Results:

No new app routes: No new page.tsx files were added in this PR

  • Changed files: nav-bar components, navigation-drawer, tests, and utils/helpers
  • This appears to be UI component changes for login/signup buttons without new routes

Coverage state: Current coverage is 100% (222/222 checkpoints, 31 journeys)

Test updates included: The PR includes test updates in:

  • components/__tests__/nav-bar.test.tsx
  • components/__tests__/navigation-drawer.test.tsx
  • utils/__tests__/helpers.test.ts

Review Decision: APPROVED

This is CASE E (no new page.tsx files and no coverage regression). No new app routes were introduced and all existing coverage remains intact. The PR includes appropriate component-level test updates for the navigation changes.


✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

@michael-on-code michael-on-code merged commit 4d76a4b into main Jun 12, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants