Feat/1821#219
Open
conradmugabe wants to merge 58 commits into
Open
Conversation
… and add corresponding tests
…or rendering tool calls
…havior and corresponding tests
…ning and tool calls
…essageBubble with tests
…kwargs in AppSidebar with tests
…omponent with tests
… collapsible details and tests
…just related tests
…and unique tool count
… checking of JS/TS files
…de formatting and type checking
Wire the existing MentorSettings.show_reasoning API field into the agent Settings tab as a Switch, mirroring the forkable/Copies toggle (form field, default from mentor?.show_reasoning, and submit payload). Includes unit tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…already streaming The 'Just a sec...' LoadingMessage gate only checked the current stream's content, so a flaky socket that retries/duplicates a generation rendered it next to a bubble already streaming (or finished). Add a single showLoadingMessage gate that also hides it when the current stream has reasoning/tool output or the last assistant message already shows any output. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy/feedback/share/report/retry only make sense on a finished response. Hide the toolbar via a 'hidden' class when isCurrentlyStreaming is true (kept mounted, not unmounted, so the copy-button ref the post-stream focus logic relies on stays valid). Buttons reappear once the message completes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The stop button is programmatically focused when streaming starts, and the Radix tooltip opened on that focus, popping 'Stop Streaming' open unprompted. Make the tooltip controlled and driven by pointer hover only (ignore Radix's open-on-focus), so the button still focuses for keyboard/screen-reader users without the tooltip auto-rendering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # .claude/settings.json # components/chat/stop-streaming-button.tsx # components/modals/edit-mentor-modal/tabs/settings-tab.tsx # e2e/COVERAGE.md # e2e/page-objects/chat.page.ts
User-facing label only — the show_reasoning API field is unchanged. Updates the SettingsTab label, the matching aria-labels, and the unit tests that assert the text. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AuthProvider from @iblai/web-utils@1.9.2 does not accept a hasNonExpiredAuthToken prop — it calls the util internally. Passing it broke `tsc --noEmit` (TS2322). The Tauri-offline guard it wrapped is already covered by the existing `skip` prop, which short-circuits the provider before any auth check runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The chat "Prompts" button is gated on the SDK's promptsIsEnabled, derived from useGetPromptsSearchQuery (true only when the mentor has >=1 suggested prompt). After adding a prompt in-place, that query result is stale on the current mount so the button never renders. Reload to force a fresh mount + refetch before asserting visibility, and drop the page.waitForTimeout anti-pattern. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Claude finished @conradmugabe's task —— View job I'm the E2E coverage bot reviewing this PR for test coverage requirements. Todo List
✅ E2E Coverage — All GoodNew routes are covered and coverage files are up to date. Verified:
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage. |
mamigot
approved these changes
Jun 5, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — All Good
New routes are covered and coverage files are up to date.
Verified:
- ✅ New route
app/platform/[tenantKey]/projects/page.tsxadded to Projects journey sourceFiles - ✅ 9 new checkpoints (proj-09 through proj-17) added covering the new projects index page
- ✅ All new checkpoints marked as "covered" with appropriate descriptions
- ✅ E2E spec file updated with corresponding test implementations
- ✅ Mechanical coverage check passed: 402 → 411 checkpoints (+9)
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage.
…ney 26 Both files' behavior is already exercised by journey 26 (proj-17 covers the No Agent Selected modal + Explore Agents navigation; proj-02 covers the ProjectLandingPage rendered by welcome-chat-new). They were missing from the journey's sourceFiles, so the coverage checker flagged them as unmapped. Add the mappings to coverage.json and COVERAGE.md — no test changes needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Claude finished @conradmugabe's task —— View job I'm the E2E coverage bot reviewing this PR for test coverage requirements. Todo List
✅ E2E Coverage — All GoodNew routes are covered and coverage files are up to date. Verified:
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage. |
mamigot
approved these changes
Jun 5, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — All Good
New routes are covered and coverage files are up to date.
Verified:
- ✅ New route
app/platform/[tenantKey]/projects/page.tsxadded to Projects journey sourceFiles - ✅ 9 new checkpoints (proj-09 through proj-17) added covering the new projects index page
- ✅ All new checkpoints marked as "covered" with appropriate descriptions
- ✅ E2E spec file updated with corresponding test implementations
- ✅ Mechanical coverage check passed: 402 → 411 checkpoints (+9)
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage.
Member
|
Claude finished @conradmugabe's task —— View job I'm the E2E coverage bot reviewing this PR for test coverage requirements. Todo List
✅ E2E Coverage — All GoodNew routes are covered and coverage files are up to date. Verified:
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage. |
mamigot
approved these changes
Jun 5, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — All Good
New routes are covered and coverage files are up to date.
Verified:
- ✅ New route
app/platform/[tenantKey]/projects/page.tsxadded to Projects journey sourceFiles - ✅ 9 new checkpoints (proj-09 through proj-17) added covering the new projects index page
- ✅ All new checkpoints marked as "covered" with appropriate descriptions
- ✅ E2E spec file updated with corresponding test implementations
- ✅ Mechanical coverage check passed: 403 → 412 checkpoints (+9)
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage.
Member
|
Claude finished @conradmugabe's task —— View job I'm the E2E coverage bot reviewing this PR for test coverage requirements. Todo List
✅ E2E Coverage — All GoodNew routes are covered and coverage files are up to date. Verified:
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage. |
mamigot
approved these changes
Jun 5, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — All Good
New routes are covered and coverage files are up to date.
Verified:
- ✅ New route
app/platform/[tenantKey]/projects/page.tsxadded to Projects journey sourceFiles - ✅ 9 new checkpoints (proj-09 through proj-17) added covering the new projects index page
- ✅ All new checkpoints marked as "covered" with appropriate descriptions
- ✅ E2E spec file updated with corresponding test implementations
- ✅ Mechanical coverage check passed: 403 → 412 checkpoints (+9)
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
conradmugabe
added
run-tests
Member
|
Claude finished @conradmugabe's task —— View job I'm the E2E coverage bot reviewing this PR for test coverage requirements. Todo List
✅ E2E Coverage — All GoodNew routes are covered and coverage files are up to date. Verified:
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage. |
mamigot
approved these changes
Jun 5, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — All Good
New routes are covered and coverage files are up to date.
Verified:
- ✅ New route
app/platform/[tenantKey]/projects/page.tsxadded to Projects journey sourceFiles - ✅ 9 new checkpoints (proj-09 through proj-17) added covering the new projects index page
- ✅ All new checkpoints marked as "covered" with appropriate descriptions
- ✅ E2E spec file updated with corresponding test implementations
- ✅ Mechanical coverage check passed: 403 → 412 checkpoints (+9)
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage.
Member
|
Claude finished @conradmugabe's task —— View job I'm the E2E coverage bot reviewing this PR for test coverage requirements. Todo List
✅ E2E Coverage — All GoodNew routes are covered and coverage files are up to date. Verified:
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage. |
mamigot
approved these changes
Jun 6, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — All Good
New routes are covered and coverage files are up to date.
Verified:
- ✅ New route
app/platform/[tenantKey]/projects/page.tsxadded to Projects journey sourceFiles - ✅ 9 new checkpoints (proj-09 through proj-17) added covering the new projects index page
- ✅ All new checkpoints marked as "covered" with appropriate descriptions
- ✅ E2E spec file updated with corresponding test implementations
- ✅ Mechanical coverage check passed: 403 → 420 checkpoints (+17)
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage.
conradmugabe
added
run-tests
Member
|
Claude finished @conradmugabe's task —— View job I'm the E2E coverage bot reviewing this PR for test coverage requirements. Todo List
✅ E2E Coverage — All GoodNew routes are covered and coverage files are up to date. Verified:
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage. |
mamigot
approved these changes
Jun 11, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — All Good
New routes are covered and coverage files are up to date.
Verified:
- ✅ New route
app/platform/[tenantKey]/projects/page.tsxadded to Projects journey sourceFiles - ✅ 9 new checkpoints (proj-09 through proj-17) added covering the new projects index page
- ✅ All new checkpoints marked as "covered" with appropriate descriptions
- ✅ E2E spec file updated with corresponding test implementations
- ✅ Mechanical coverage check passed: 419 → 436 checkpoints (+17)
The PR properly implements the new dedicated Projects page (feat-1821) with comprehensive E2E coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Changes
Screenshots
Screencast.from.2026-06-01.04-45-52.mp4