Skip to content

fix(mentor): show share button to anonymous users#227

Merged
sonegillis1 merged 1 commit into
mainfrom
fix/1546
Jun 11, 2026
Merged

fix(mentor): show share button to anonymous users#227
sonegillis1 merged 1 commit into
mainfrom
fix/1546

Conversation

@conradmugabe

Copy link
Copy Markdown
Contributor

Anonymous users (who open a chat via a shareable token link rather than logging in) were unable to share a chat because the share button was gated behind isLoggedIn(). The backend now authorizes anonymous principals on the session-sharing endpoint, so gate the button only by the read-only shared-chat view.

Checklist

  • Tests were added/updated according to the feature/bugfix/change made
  • Version was rolled according to semver requirements
  • API endpoints openapi schema was updated if applicable

Changes

Anonymous users (who open a chat via a shareable token link rather than
logging in) were unable to share a chat because the share button was
gated behind isLoggedIn(). The backend now authorizes anonymous
principals on the session-sharing endpoint, so gate the button only by
the read-only shared-chat view.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@conradmugabe conradmugabe requested a review from mamigot as a code owner June 8, 2026 04:11
@conradmugabe conradmugabe self-assigned this Jun 8, 2026
@mamigot

mamigot commented Jun 8, 2026

Copy link
Copy Markdown
Member

Claude finished @conradmugabe's task —— View job


E2E Coverage Review ✅

Tasks:

  • Dismiss stale REQUEST_CHANGES reviews from bot
  • Identify what changed in this PR
  • Run mechanical coverage check
  • Read current coverage state
  • Apply decision logic and post GitHub review

PR Details:

  • Branch: fix/1546 -> main
  • Files changed: 3 files (CHANGELOG.md, test file, component file)
  • Change: Fix share button visibility for anonymous users

Analysis:

  • No new page.tsx files detected
  • Changes are to existing components only:
    • components/chat/ai-message-bubble.tsx - component logic change
    • components/chat/__tests__/ai-message-bubble.test.tsx - test updates
    • CHANGELOG.md - changelog entry

Coverage Check Results:

  • ✅ Mechanical coverage check PASSED
  • ✅ No coverage regression (403 checkpoints maintained)
  • ✅ All existing app routes remain covered (24/24 files mapped, 100%)
  • ✅ No new routes requiring coverage

Decision: This falls under CASE E - No new page.tsx files and mechanical check passed.

Result:PR APPROVED - No E2E coverage issues detected.


@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

@conradmugabe conradmugabe added the run-tests Trigger PR validation pipeline label Jun 11, 2026
@sonegillis1 sonegillis1 merged commit 63b2b23 into main Jun 11, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests Trigger PR validation pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants