feat: added onboarding#243
Conversation
|
Claude finished @null-crafter's task —— View job I'm reviewing this PR for E2E test coverage as the E2E coverage bot. Todo List
Coverage Issues DetectedIssue 1: Coverage Regression
Issue 2: Missing E2E Coverage
Analysis: This falls under CASE A - New route added but NO new e2e spec and NO coverage update. |
mamigot
left a comment
There was a problem hiding this comment.
❌ E2E Coverage Required
This PR adds new routes but does not include e2e journey tests or coverage updates.
Missing coverage for:
app/onboarding/page.tsx- New onboarding route needs journey coverage
Additional Issue:
- Coverage regression detected: checkpoint count decreased from 412 to 403 (−9 checkpoints)
- Removing test coverage is not allowed without replacement
To fix:
- Add a journey spec in
e2e/journeys/testing the onboarding feature - In
e2e/coverage.json: add the route tosourceFiles[]and add checkpoint entries with"status": "covered" - In
e2e/COVERAGE.md: add matching[x]checkpoint lines - Restore the 9 missing checkpoints or justify their removal
Coverage check output:
Coverage REGRESSION: checkpoints decreased from 412 to 403 (−9)
NEW ROUTES without E2E journey coverage:
app/onboarding/page.tsx
Run locally to verify:
node e2e/scripts/check-journey-coverage.mjs --all|
Claude finished @null-crafter's task —— View job Claude finished @null-crafter's task —— View job I've completed the E2E coverage review for this PR. Todo List
Coverage Issues DetectedIssue 1: Coverage Regression
Issue 2: Missing E2E Coverage
Analysis: This falls under CASE A - New route added but NO new e2e spec and NO coverage update. Action Taken: Posted a REQUEST_CHANGES review requiring the developer to add E2E journey tests for the new onboarding route and restore the missing checkpoints. |
mamigot
left a comment
There was a problem hiding this comment.
❌ E2E Coverage Required
This PR adds new routes but does not include e2e journey tests or coverage updates.
Missing coverage for:
app/onboarding/page.tsx- New onboarding route needs journey coverage
Additional Issue:
- Coverage regression detected: checkpoint count decreased from 419 to 412 (−7 checkpoints)
- Removing test coverage is not allowed without replacement
To fix:
- Add a journey spec in
e2e/journeys/testing the onboarding feature - In
e2e/coverage.json: add the route tosourceFiles[]and add checkpoint entries with"status": "covered" - In
e2e/COVERAGE.md: add matching[x]checkpoint lines - Restore the 7 missing checkpoints or justify their removal
Coverage check output:
Coverage REGRESSION: checkpoints decreased from 419 to 412 (−7)
NEW ROUTES without E2E journey coverage:
app/onboarding/page.tsx
Run locally to verify:
node e2e/scripts/check-journey-coverage.mjs --all
Checklist
Changes
Adds onboarding as provided by https://github.com/iblai/iblai-web-frontend/pull/1871